Skip to content

Add support for GLSL source-level debugging with RenderDoc - #77975

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
sakrel:shader_debug_info
Aug 16, 2023
Merged

Add support for GLSL source-level debugging with RenderDoc#77975
akien-mga merged 1 commit into
godotengine:masterfrom
sakrel:shader_debug_info

Conversation

@sakrel

@sakrel sakrel commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

This PR adds a command line argument (--generate-spirv-debug-info) that makes glslang embed additional debug info necessary for source-level debugging with RenderDoc.

See this presentation for more details: https://www.khronos.org/assets/uploads/developers/presentations/Source-level_Shader_Debugging_in_Vulkan_with_RenderDoc_VULOCT2022.pdf

https://renderdoc.org/docs/how/how_debug_shader.html

@sakrel
sakrel requested review from a team as code owners June 7, 2023 18:18
@sakrel
sakrel force-pushed the shader_debug_info branch from 49d1915 to 7ff8ae9 Compare June 7, 2023 18:19
Comment thread modules/glslang/register_types.cpp Outdated
Comment thread modules/glslang/register_types.cpp Outdated
@sakrel
sakrel force-pushed the shader_debug_info branch from 7ff8ae9 to 80a36ff Compare August 12, 2023 12:59

@clayjohn clayjohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Let's go ahead with this for now and then we can rebase #78883 on top.

This is not suitable for cherrypicking.

@clayjohn clayjohn modified the milestones: 4.x, 4.2 Aug 15, 2023
@akien-mga
akien-mga merged commit b44867b into godotengine:master Aug 16, 2023
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
Add support for GLSL source-level debugging with RenderDoc
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
Add support for GLSL source-level debugging with RenderDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants