Remove spaces from input of HTML color in color picker - #79345
Conversation
|
I'd say the commit description is a bit verbose, should just contain the information about what it does, not arguments in favour, they should be in the PR description |
There was a problem hiding this comment.
I think the comment is uneeded, pretty self explanatory
There was a problem hiding this comment.
I tried to explain why I changed that line, but after reading through my comment again... Yep, I must admit that this is quite a repetition.
|
I attempted to adress the why rather than the what in my commit body (since the what can usually be read from the code changes).
|
|
I would say the title says it all |
|
I've updated my commit according to your suggestions. (I might be more of a book author rather than a short and precise commit message author. 😉 That was indeed a lot of duplication!) |
|
@guemax Did you mean to close this pull request? The PR itself seems good to me, I think it's in a mergeable state. It needs to be reopened first, but since you removed your fork repository, you'll need to create a new pull request. |
|
Oh, I was simply deleting some old repositories, and have somehow managed to delete my fork of Godot as well. That was a dumb idea! Thanks for pointing this out. 👍 (As @AThousandShips commented, I opened a new pull request) |
The color picker is now much more liberal about the user input, and simply removes the spaces before passing the string for further processing.
This is especially useful when copy-pasting HTML color codes from color palettes, as there is always the chance of accidentally copying some spaces as well. Having to remove them manually is quite tedious and not as intuitive as it could be.
Accepting valid HTML color codes with spaces is also the default behavior of programs with similar color picker functionality such as Affinity Designer, Blender, or Gimp.