Add size check to prevent popup bigger than the screen itself - #79617
Merged
Conversation
sepTN
force-pushed
the
add-screensize-check-popup
branch
2 times, most recently
from
July 18, 2023 16:29
3eb17f7 to
8123453
Compare
sepTN
marked this pull request as draft
July 18, 2023 16:51
sepTN
force-pushed
the
add-screensize-check-popup
branch
from
July 18, 2023 18:09
38c4961 to
8afdde8
Compare
sepTN
marked this pull request as ready for review
July 18, 2023 18:46
bruvzg
reviewed
Jul 19, 2023
sepTN
force-pushed
the
add-screensize-check-popup
branch
from
July 19, 2023 12:35
b12c297 to
38095eb
Compare
Sauermann
approved these changes
Feb 18, 2024
Sauermann
left a comment
Contributor
There was a problem hiding this comment.
While I haven't tested the PR, the changes seem to solve the linked issue and I don't see any obvious problems with the implementation.
AThousandShips
approved these changes
Feb 18, 2024
Contributor
Author
|
Thanks! I'll git squash to a single commit in a bit. |
sepTN
force-pushed
the
add-screensize-check-popup
branch
from
February 18, 2024 17:29
fff674f to
34210e8
Compare
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…popup Add size check to prevent popup bigger than the screen itself
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…popup Add size check to prevent popup bigger than the screen itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add size check to prevent popup bigger than the screen itself.
Fix #78594 however I'm not sure if this is the correct way to do it. Maybe if there's someone who can point me in the right direction.
First, as per the issue #78594 to cause the freeze, have a ridiculous dialog_bounds value in your:
.godot/editor/project_metadata.cfgSecond, open your Project Settings.
Before (without this pr)
After (with this pr applied)