Use existing plugin.cfg in configuration dialog - #79723
Merged
akien-mga merged 1 commit intoApr 26, 2024
Hidden character warning
The head ref may contain hidden characters: "tfw_you_single-linedly_implement_a_proposal\ud83d\ude0e"
Merged
Conversation
Contributor
|
As already stated in the issue, wouldn't it be better to avoid loading the file twice? |
Member
Author
|
It doesn't matter. It's still better than project metadata, which is loaded with every access 🙃 |
akien-mga
approved these changes
Apr 26, 2024
akien-mga
left a comment
akien-mga
left a comment
Member
There was a problem hiding this comment.
Looks good. Would rebase for good measure.
KoBeWi
force-pushed
the
tfw_you_single-linedly_implement_a_proposal
branch
from
April 26, 2024 12:38
15c4602 to
7b3da23
Compare
Member
|
Thanks! |
akien-mga
changed the title
plugin.cfgplugin.cfg in configuration dialog
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…ly_implement_a_proposal😎 Use existing `plugin.cfg`
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…ly_implement_a_proposal😎 Use existing `plugin.cfg`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#7324