Fix generated light probes placing too close to manual light probes - #83497
Merged
Conversation
…anual light probes
clayjohn
added
the
cherrypick:4.3
clayjohn
approved these changes
Jul 24, 2024
clayjohn
left a comment
clayjohn
left a comment
Member
There was a problem hiding this comment.
This seems to have slipped through the cracks. My apologies.
The code seems reasonable and fairly low risk. So let's go ahead and merge this earlier in the 4.4 dev cycle
Calinou
approved these changes
Jul 24, 2024
Member
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Member
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Fix generated light probes placing too close to manual light probes
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Fix generated light probes placing too close to manual light probes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from a conversation here: #83420.
While poking around in
lightmap_gi, I noticed there is code to avoid generating probes too close to manually placed probes, but it was doing anis_equal_approxcheck against the two positions instead of a distance check, so this was never being triggered. I changed it to a distance check so the behavior is as expected now: