Fixed 3D physics zero impulse contact reporting #85764
Open
+19
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthLeviN
force-pushed
the
zero_impulse_3d_fix
branch
from
ab6569b to
1107b34
Compare
|
Whoops, wrong PR In any case, this will need a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where collisions go reported with zero impulse when a contact starts.
This is because the impulse is calculated AFTER the data gets submited.
I moved the submission to the solve step. I don't know if this interferes with multithreading. please test.
Fixes #73541
My Minimal reproduction project for the bug :
collision_reporting_1.zip
Never mind the late assert. the only important one is for first contact.
Relates to #81654
Should i follow the same approach as this pull request instead? Does my method create duplicate collisions?