-
-
Notifications
You must be signed in to change notification settings - Fork 23k
[Shaders] Disallow trailing commas in function declarations #87075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AThousandShips
wants to merge
1
commit into
godotengine:master
Choose a base branch
from
AThousandShips:shader_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Jan 11, 2024
Tested and it doesn't look good and isn't noticeable, also feels like a bad idea to add a new warning category just for this to allow it to be configured well |
2d211f1
to
2c0abaf
Compare
2c0abaf
to
46e1b34
Compare
46e1b34
to
94165e5
Compare
94165e5
to
39acc83
Compare
39acc83
to
706b910
Compare
706b910
to
65ec7a0
Compare
65ec7a0
to
6b8c867
Compare
6b8c867
to
eec6ed5
Compare
328a4ae
to
22db465
Compare
22db465
to
52b2649
Compare
52b2649
to
59a54b0
Compare
59a54b0
to
70edbd8
Compare
70edbd8
to
49bf827
Compare
49bf827
to
a5b67ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might not be the most elegant fix, but not very familiar with this code, if someone has a cleaner idea for doing this I'd appreciate suggestions. Added it with deprecation to avoid breaking existing shaders, though I'm not sure that's necessary
I was considering enclosing the whole
while
loop in a block to check closing paren at the start, which would make catching this easier, but want to avoid noise in the blame if I can, having to indent the whole thing.For reasoning, see the discussion in:
Alternative to: