Skip to content

Resource file not found error when loading Favorite icon - #89642

Merged
1 commit merged into
godotengine:masterfrom
permelin:fix-favorite-icon
Mar 24, 2024
Merged

Resource file not found error when loading Favorite icon#89642
1 commit merged into
godotengine:masterfrom
permelin:fix-favorite-icon

Conversation

@permelin

Copy link
Copy Markdown
Contributor

The order of two arguments were flipped in recently merged #77932. If you had any favorites in the file dock, you would get ERROR: Resource file not found: res://PackedScene (expected type: ) cc: @KoBeWi.

@permelin
permelin requested a review from a team March 18, 2024 12:21
@permelin

Copy link
Copy Markdown
Contributor Author

Maybe don't merge this until #89646 is resolved.

@KoBeWi

KoBeWi commented Mar 18, 2024

Copy link
Copy Markdown
Member

How is this related to that issue? Does removing the error make it even slower?

@permelin

permelin commented Mar 18, 2024

Copy link
Copy Markdown
Contributor Author

How is this related to that issue? Does removing the error make it even slower?

There is no slowdown at all until you apply this fix. The error means that no scene files are loaded for the favorites, and loading the scenes is what is causing the slowdown as far as I can tell.

@permelin
permelin force-pushed the fix-favorite-icon branch from 264a767 to ae6410b Compare March 18, 2024 21:19
@permelin

Copy link
Copy Markdown
Contributor Author

Pushed an update. This PR now fixes:

  1. Flipped argument order causing error message.
  2. Slowdown caused by trying to load an entire scene as an icon.
  3. Custom icons were not shown if you run the file dock in split mode.

@AThousandShips
AThousandShips requested a review from KoBeWi March 18, 2024 21:30
@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
Resource file not found error when loading Favorite icon
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@permelin
permelin deleted the fix-favorite-icon branch April 16, 2024 13:10
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
Resource file not found error when loading Favorite icon
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
Resource file not found error when loading Favorite icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants