feat: add webhook cmd by rizul2108 · Pull Request #391 · goharbor/harbor-cli

rizul2108 · 2025-04-10T19:30:16Z

Description

This pull request continues the work initiated in #166

Changes and Improvements

Resolved merge conflicts present in PR feat: add webhook cmd #166.
Added documentation for the newly introduced commands.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 · 2025-04-12T05:58:28Z

Screencast.from.12-04-25.11.27.17.AM.IST.webm

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 · 2025-04-12T10:42:17Z

@bupd ready for review

Copilot

Copilot reviewed 19 out of 24 changed files in this pull request and generated 1 comment.

Files not reviewed (5)

doc/man-docs/man1/harbor-webhook-create.1: Language not supported
doc/man-docs/man1/harbor-webhook-delete.1: Language not supported
doc/man-docs/man1/harbor-webhook-edit.1: Language not supported
doc/man-docs/man1/harbor-webhook-list.1: Language not supported
doc/man-docs/man1/harbor-webhook.1: Language not supported

Comments suppressed due to low confidence (1)

cmd/harbor/root/webhook/delete.go:67

[nitpick] The flag name 'webhook' is inconsistent with other commands (e.g., edit uses '--webhook-id'); consider renaming it to '--webhook-id' for clarity and consistency.

flags.StringVarP(&webhookId, "webhook", "", "", "Webhook ID")

bupd

same here need better validation

and also screenshots of each cmd working

rizul2108 · 2025-04-15T12:29:33Z

same here need better validation

and also screenshots of each cmd working

I have added the screen-recording of working of the command instead of screenshots does it work
Or should i add screenshots

support yaml Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> add valiators Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

Copilot

Pull Request Overview

This PR continues the work from PR #166 by introducing webhook commands and enhancing input validation for Harbor CLI.

Added URL and empty string validator utilities in pkg/utils/helper.go
Introduced new webhook-related CLI commands (list, create, edit, delete) and integrated them with the API and interactive prompt
Updated and extended the CLI documentation to cover the new webhook functionality

Reviewed Changes

Copilot reviewed 19 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/utils/helper.go	New helper functions for URL validation and empty string checking
pkg/prompt/prompt.go	Added GetWebhookFromUser for interactive selection of webhook
pkg/api/webhook_handler.go	Implements listing, creating, deleting, and updating webhook policies
doc/cli-docs/*.md	Updated CLI docs to include webhook commands
cmd/harbor/root/webhook/*.go	New commands for managing webhooks (list, create, edit, delete)
cmd/harbor/root/cmd.go	Registered the new webhook command with the root command

Files not reviewed (5)

doc/man-docs/man1/harbor-webhook-create.1: Language not supported
doc/man-docs/man1/harbor-webhook-delete.1: Language not supported
doc/man-docs/man1/harbor-webhook-edit.1: Language not supported
doc/man-docs/man1/harbor-webhook-list.1: Language not supported
doc/man-docs/man1/harbor-webhook.1: Language not supported

Comments suppressed due to low confidence (1)

cmd/harbor/root/webhook/delete.go:67

The flag for the webhook ID is named 'webhook', whereas in the edit command it is 'webhook-id'. Standardizing the flag naming across commands would improve clarity and consistency.

flags.StringVarP(&webhookId, "webhook", "", "", "Webhook ID")

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

…to continue-webhook

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

Copilot

Pull Request Overview

This pull request continues the work from #166 by resolving merge conflicts and adding new commands and documentation for managing webhooks in Harbor.

Resolved merge conflicts from a previous PR
Added implementation for webhook commands in the CLI (list, create, edit, delete)
Updated documentation to cover new webhook functionalities

Reviewed Changes

Copilot reviewed 20 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/utils/helper.go	Added EmptyStringValidator helper function
pkg/prompt/prompt.go	Introduced GetWebhookFromUser for interactive webhook selection
pkg/api/webhook_handler.go	Added webhook API functions (list, create, update, delete)
doc/cli-docs/*.md	Updated and added CLI documentation for webhook commands
cmd/harbor/root/webhook/*.go	Implemented CLI commands for webhook management
cmd/harbor/root/cmd.go	Integrated webhook command into the main CLI command structure

Files not reviewed (5)

doc/man-docs/man1/harbor-webhook-create.1: Language not supported
doc/man-docs/man1/harbor-webhook-delete.1: Language not supported
doc/man-docs/man1/harbor-webhook-edit.1: Language not supported
doc/man-docs/man1/harbor-webhook-list.1: Language not supported
doc/man-docs/man1/harbor-webhook.1: Language not supported

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

bupd

I have some ideas for improvement.

please maintain consistency among other commands.

bupd · 2025-04-25T21:44:34Z

❯ ./bin/harbor-dev webhook edit --project kumar --name paandi  --description  update

the edit cmd spawns project selection eventhough I specified the project.

fix edit sub-cmd Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> implement changes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> lint fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> left align fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> fix left alignment Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

test create cmd Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> test all cmds Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> lint fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

bupd

lgtm

Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 · 2025-05-12T11:24:15Z

@Vad1mo ready to merge

35C4n0r and others added 13 commits August 15, 2024 22:33

feat: add create webhook cmd

16537a6

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

feat: add list webhook cmd

a8a71ab

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

feat: add delete webhook cmd

7031205

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

feat: add edit webhook cmd

2b5b44e

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

chore: add flags for edit webhook cmd

09c9a98

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

feat: feature to disable webhooks

ed1634a

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>

Merge branch 'main' into continue-webhook

2904916

fixes and add headers

f969837

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

add docs

a3f01cf

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

fix lint issues

01f5964

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

fix lint issues

d33a64a

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

small fixes

c2b3ddd

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

update desc and docs

574c1db

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

small fix

8d5b85c

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 requested a review from Copilot April 15, 2025 05:23

Copilot AI reviewed Apr 15, 2025

View reviewed changes

Comment thread cmd/harbor/root/webhook/edit.go Outdated

bupd requested changes Apr 15, 2025

View reviewed changes

Comment thread cmd/harbor/root/webhook/list.go

rizul2108 force-pushed the continue-webhook branch from 78b73eb to faf959e Compare April 15, 2025 14:41

add validators and support yaml

89067ab

support yaml Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> add valiators Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 force-pushed the continue-webhook branch from c4da5a6 to 89067ab Compare April 18, 2025 05:19

rizul2108 requested a review from Copilot April 18, 2025 05:19

Copilot AI reviewed Apr 18, 2025

View reviewed changes

Comment thread cmd/harbor/root/webhook/edit.go Outdated

Comment thread pkg/prompt/prompt.go Outdated

rizul2108 and others added 4 commits April 18, 2025 10:52

Update cmd/harbor/root/webhook/edit.go

0f26f02

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

Merge branch 'goharbor:main' into continue-webhook

86271e6

Merge branch 'main' into continue-webhook

8cf4b58

Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

Merge branch 'main' into continue-webhook

cb12aa6

rizul2108 added 2 commits April 23, 2025 16:14

Merge branch 'continue-webhook' of github.com:rizul2108/harbor-cli in…

c408659

…to continue-webhook

user abortion handling

f03d6dd

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 requested a review from Copilot April 23, 2025 11:17

Copilot AI reviewed Apr 23, 2025

View reviewed changes

lint fix

f0e1586

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 requested a review from bupd April 24, 2025 14:05

bupd requested changes Apr 25, 2025

View reviewed changes

Comment thread cmd/harbor/root/webhook/create.go Outdated

Comment thread cmd/harbor/root/webhook/delete.go Outdated

Comment thread pkg/views/webhook/create/view.go Outdated

rizul2108 force-pushed the continue-webhook branch from 6622ca1 to 8d7691a Compare April 28, 2025 13:08

Vad1mo changed the title ~~Continuing Work from #166: add webhook cmd~~ feat: add webhook cmd Apr 29, 2025

rizul2108 added 2 commits May 3, 2025 15:20

Merge branch 'main' into continue-webhook

cca0dee

test cmds and make changes

12c3c2f

test create cmd Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> test all cmds Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> lint fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 force-pushed the continue-webhook branch from 3ea1b26 to 12c3c2f Compare May 3, 2025 10:37

small fix

30a7e4a

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

bupd approved these changes May 6, 2025

View reviewed changes

bupd added the enhancement New feature or request label May 6, 2025

rizul2108 and others added 2 commits May 12, 2025 13:01

Merge branch 'main' into continue-webhook

f942409

Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

fix code and docs

e411a11

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

Vad1mo merged commit 2a84670 into goharbor:main May 13, 2025
7 checks passed

RafsanNeloy mentioned this pull request Aug 3, 2025

📌 Tracker: Missing and To-Be-Added CLI Commands #94

Open

16 tasks

Conversation

rizul2108 commented Apr 10, 2025

Description

Changes and Improvements

Uh oh!

rizul2108 commented Apr 12, 2025

Uh oh!

rizul2108 commented Apr 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

rizul2108 commented Apr 15, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bupd commented Apr 25, 2025

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

rizul2108 commented May 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants