Add ID to Claims interface#352
Open
st3fan wants to merge 2 commits into
Open
Conversation
Collaborator
|
This looks like a good idea, unfortunately this is API breaking, so this is something we need to keep reserved for a future |
Closed
oxisto
added
next
oxisto
reviewed
Jan 28, 2026
| GetIssuer() (string, error) | ||
| GetSubject() (string, error) | ||
| GetAudience() (ClaimStrings, error) | ||
| GetID() (string, error) |
Collaborator
There was a problem hiding this comment.
So in the spec this is called JWT ID, we tried to take the "name" of the claim of the spec and use that for the name of the function, so in that case it would be GetJWTID() although I am not really sure if this is a good name. Canonical Go would probably be GetJwtId()?
Collaborator
|
Let's do this, should be one of the first things that will land in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the
jticlaim to theClaimsinterface with aGetID()method. It also implementsGetID()for bothMapClaimsandRegisteredClaims.This makes it easier to use the registered claims (as documented in https://datatracker.ietf.org/doc/html/rfc7519#section-4.1) when you don't know whether you have an instance of
RegisteredClaimsorMapClaimsto work with.(I have a a concrete use for this where it saves me a type switch to find out what type of claims I am working with)
I realize that this is a drive-by pull request - if this change is unwanted then please discard it.