Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion claims.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ package jwt
// common basis for validation, it is required that an implementation is able to
// supply at least the claim names provided in
// https://datatracker.ietf.org/doc/html/rfc7519#section-4.1 namely `exp`,
// `iat`, `nbf`, `iss`, `sub` and `aud`.
// `iat`, `nbf`, `iss`, `sub`, `aud` and `jti`.
type Claims interface {
GetExpirationTime() (*NumericDate, error)
GetIssuedAt() (*NumericDate, error)
GetNotBefore() (*NumericDate, error)
GetIssuer() (string, error)
GetSubject() (string, error)
GetAudience() (ClaimStrings, error)
GetID() (string, error)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the spec this is called JWT ID, we tried to take the "name" of the claim of the spec and use that for the name of the function, so in that case it would be GetJWTID() although I am not really sure if this is a good name. Canonical Go would probably be GetJwtId()?

}
5 changes: 5 additions & 0 deletions map_claims.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ func (m MapClaims) GetSubject() (string, error) {
return m.parseString("sub")
}

// GetID implements the Claims interface.
func (m MapClaims) GetID() (string, error) {
return m.parseString("jti")
}

// parseNumericDate tries to parse a key in the map claims type as a number
// date. This will succeed, if the underlying type is either a [float64] or a
// [json.Number]. Otherwise, nil will be returned.
Expand Down
5 changes: 5 additions & 0 deletions registered_claims.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,8 @@ func (c RegisteredClaims) GetIssuer() (string, error) {
func (c RegisteredClaims) GetSubject() (string, error) {
return c.Subject, nil
}

// GetID implements the Claims interface.
func (c RegisteredClaims) GetID() (string, error) {
return c.ID, nil
}