-
Notifications
You must be signed in to change notification settings - Fork 41
Model batching v2 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model batching v2 #195
Conversation
Plan after offline discussion @erikfrey:
|
PR is updated to remove the helper function and just use either stride 0 or an array that has nworld as first dimension, with users responsible for filling that array correctly. @erikfrey I consider this ready for review - I mostly need input on what fields should be batchable. @btaba - do you by any chance have an example learning workflow around where I could test-drive this? My main worry right now is that I don't see a good way uf unittesting this, because we are just replacing arrays at runtime. We would either have to validate shapes at runtime (expensive) or add another layer/help that is mandatory. |
closing in favor of #231 |
replaces #109 - annoying not to keep the discussion there..
This now does the modulo approach with helpers.