Align proto definition vs generated code #1747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he go package of the checked in generated proto code at https://github.com/google/certificate-transparency-go/blob/master/client/configpb/multilog.pb.go
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
You can run the following command to regenerate the proto files. docker build -f ./integration/Dockerfile -t ctgo-builder .
docker run -it --mount type=bind,src="$(pwd)",target=/src ctgo-builder /bin/bash -c "cd /src; ./scripts/install_deps.sh; go generate -x ./..." |
Author
|
Regenerating the proto file with that command will have no effect, the location of the generated proto file is the problem and not its contents. Changing the declaration within the proto file is the easier fix, rather than changing all the code that refers to it |
Contributor
|
The following content in the generated proto go file will be changed after the regeneration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the go package declared in the proto definition to agree with the go package of the checked in generated proto code at https://github.com/google/certificate-transparency-go/blob/master/client/configpb/multilog.pb.go