Clarify that class Ascii is from Guava. #4951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids initial confusion for stupid users (like me!) who when working outside of Google internal codebase and when first encountering this error go look for class Ascii in the JDK.
vorburger
added a commit
to vorburger/MariaDB4j
that referenced
this pull request
Mar 28, 2025
…e rule enforced in this project See https://errorprone.info/bugpattern/StringCaseLocaleUsage (and google/error-prone#4951)
vorburger
added a commit
to vorburger/MariaDB4j
that referenced
this pull request
Mar 28, 2025
…e rule enforced in this project See https://errorprone.info/bugpattern/StringCaseLocaleUsage (and google/error-prone#4951)
vorburger
added a commit
to vorburger/MariaDB4j
that referenced
this pull request
Mar 28, 2025
…e rules enforced in this project See https://errorprone.info/bugpattern/UnrecognisedJavadocTag (which, very strangely, I cannot reproduce locally; only happens on CI?!), and https://errorprone.info/bugpattern/StringCaseLocaleUsage (and google/error-prone#4951).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids initial confusion for stupid users (like me!) who when working outside of Google internal codebase and when first encountering this error go look for a class
Asciiin the JDK.@cushon how about this? Or would rather prefer not?