vm/qemu: skip register collection for non-crash reports #6450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georghegel
force-pushed
the
qemugo-todo-patch
branch
from
4c7e8f1 to
470eee7
Compare
Contributor
Author
|
Also wanted to add that maybe some of them should be corrected and return as crash too. Since Im not sure should we point that KMSANU, MemoryLeak and similar are crashes too. |
georghegel
force-pushed
the
qemugo-todo-patch
branch
2 times, most recently
from
422c7aa to
76dc5bc
Compare
a-nogikh
reviewed
Nov 18, 2025
georghegel
force-pushed
the
qemugo-todo-patch
branch
from
76dc5bc to
48efbb0
Compare
a-nogikh
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Diagnose() function were "TODO" for optimising collection of logs for non-crash reports.
Added this little fix.
Probably code itself isn't quiet good in terms of Google Code Style, but I'm not sure.
I'm working on arm64, thus I checked only on unit tests, linters and go fmt.
Appropriate question was made by me here in googlegroups