Skip to content

fix(tools/looker): address feedback for agent tool#2834

Merged
drstrangelooker merged 2 commits intogoogleapis:looker-agentfrom
hiracky16:fix/looker-agent-upstream
Mar 25, 2026
Merged

fix(tools/looker): address feedback for agent tool#2834
drstrangelooker merged 2 commits intogoogleapis:looker-agentfrom
hiracky16:fix/looker-agent-upstream

Conversation

@hiracky16
Copy link
Copy Markdown
Contributor

Description

Addresses the feedback from the maintainers regarding the looker-agent tool.
ref: #2830

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@hiracky16 hiracky16 requested review from a team as code owners March 24, 2026 21:44
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the looker-agent tool by addressing previous feedback, primarily focusing on enhancing its documentation. The changes provide a much clearer and more comprehensive guide for users on how to configure and utilize the tool, detailing its various operations and their respective parameters. This improves usability and reduces potential confusion for developers integrating the looker-agent.

Highlights

  • Documentation Enhancement: The looker-agent tool's documentation has been significantly expanded to provide a clear, detailed description of its operations (list, get, create, delete) and the required parameters for each.
  • Configuration Example Update: The YAML configuration example for the looker-agent tool in the documentation was updated to reflect a more standard tools: array structure and to incorporate the detailed parameter descriptions.
  • Test Consistency: A test case for parsing YAML configurations for the looker-agent tool was updated to use the agent_manage name, ensuring consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the looker-agent tool, providing a more detailed YAML configuration example with specific parameters for operations like listing, getting, creating, and deleting agents. It also removes a redundant reference table from the documentation and updates a test case to reflect the new tool name. However, the provided YAML configuration example in the documentation is incorrect as it uses a tools: list instead of the expected kind: tool top-level definition.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@drstrangelooker drstrangelooker merged commit 8905e5b into googleapis:looker-agent Mar 25, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants