feat(tools/looker): Looker agent management from MCP by drstrangelooker · Pull Request #2830 · googleapis/genai-toolbox

drstrangelooker · 2026-03-24T19:14:37Z

Description

Looker agent management from MCP

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

Make sure you reviewed
CONTRIBUTING.md
Make sure to open an issue as a
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Make sure to add ! if this involve a breaking change

🛠️ Fixes #2827

gemini-code-assist · 2026-03-24T19:14:55Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new tool into the system that allows for the programmatic management of Looker Agents. This enhancement provides LLMs with direct capabilities to interact with Looker Agent resources, streamlining automation and extending the platform's reach into Looker's agent ecosystem. The changes include the core implementation of the tool, its registration within the command-line interface, and comprehensive user documentation.

Highlights

New Looker Agent Management Tool: A new looker-agent tool has been introduced, enabling Large Language Models (LLMs) to manage Looker Agents directly from the Multi-Cloud Platform (MCP).
CRUD Operations for Looker Agents: The new tool supports list, get, create, and delete operations for Looker Agents, leveraging the Looker Go SDK.
Comprehensive Documentation: Detailed documentation for the looker-agent tool has been added, covering its configuration, parameters, and usage examples for each supported operation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

drstrangelooker · 2026-03-24T19:15:20Z

@hiracky16 lets continue from here so that all the tests run properly.

drstrangelooker · 2026-03-24T19:18:33Z

Do you want this to be in a prebuilt tool set? Also we should have some integration tests in tests/looker/looker_integration_test.go. These run against the looker instance sandbox.looker-devrel.com.

github-actions · 2026-03-24T19:19:36Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

gemini-code-assist

Code Review

This pull request introduces a new looker-agent tool, enabling LLMs to perform CRUD operations (list, get, create, delete) on Looker agents. The changes include the tool's core implementation, registration, documentation, and unit tests. Feedback from the review suggests adhering to naming conventions for tool names as per the style guide, utilizing NewStringParameterWithAllowedValues for more robust parameter validation, and dynamically referencing the tool's name in debug logs for improved maintainability.

docs/en/resources/tools/looker/looker-agent.md

internal/tools/looker/lookeragent/lookeragent.go

internal/tools/looker/lookercreateagent/lookercreateagent_test.go

docs/en/resources/tools/looker/looker-agent.md

github-actions · 2026-03-24T19:33:55Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

drstrangelooker · 2026-03-24T19:39:32Z

@hiracky16 I didn't realise you weren't a googler. You may not be able to commit to this branch. If you fork this branch and the set PRs against it I'll merge them in.

hiracky16 · 2026-03-24T21:57:40Z

@drstrangelooker Thank you for the suggestion. I've significantly expanded the description field in the documentation to include detailed instructions for LLMs, explaining each operation and its required parameters. This should make it much easier for agents to use the tool correctly.
Please review #2834

## Description Addresses the feedback from the maintainers regarding the `looker-agent` tool.

github-actions · 2026-03-25T14:26:33Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

github-actions · 2026-03-25T14:30:26Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

…r for agent tool (#2864) ## Description This PR significantly enhances the `looker-agent` tool by adding missing parameters required for effective agent management. In the initial implementation, only `name` and `description` (internal) were supported. However, crucial fields for Looker AI Agents such as `instructions` (system prompt), `sources` (data models/explores), and `code_interpreter` were missing. This update fills those gaps and also introduces an update operation. ## Changes - New Parameters: Added `instructions`, `sources` (JSON-encoded array), and `code_interpreter` (boolean) to both `create` and `update` operations. - Update Operation: Implemented the `update` operation to allow modification of existing agents. - Robustness: - Updated error handling to use `http.StatusBadRequest` for client-side validation errors. - Added safety checks for parameter access to prevent runtime panics. - Enhanced Testing: Rewrote and expanded unit tests to cover all new parameters, operations, and validation logic (including MCP manifest verification). - Documentation: Updated the tool's documentation with detailed LLM instructions and usage examples for all new fields. ## Impact The `looker-agent` tool is now fully capable of managing the complete lifecycle and configuration of Looker AI Agents, enabling sophisticated analytical workflows. ## Verification - Comprehensive unit tests added and passed: go test -v ./internal/tools/looker/lookeragent/... - Verified MCP manifest generation and schema correctness.

hiracky16 · 2026-03-29T22:13:50Z

@drstrangelooker
Following up on your previous guidance about creating a PR against this branch, I've just opened a new one to address the remaining feedback and enhance the tool: PR #2887 : fix(tools/looker): address CI failures and enhance agent tool functionality.

Please let me know if there's anything else needed to merge #2830! I'm happy to make further adjustments as required.

…nality (#2887) …ort agent instructions/update ## Description This PR addresses CI failures observed in #2830 and enhances the `looker-agent` tool with missing functionality and improved robustness. Based on the CI results in #2830, I have fixed the linting issues and the documentation build error. I have also taken this opportunity to implement essential missing features such as agent instructions and update operations. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

github-actions · 2026-03-30T20:34:02Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

drstrangelooker · 2026-03-30T20:35:18Z

@hiracky16 I had to refactor the docs to go with the changed documentation structure.

github-actions · 2026-03-30T20:39:36Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

docs/en/integrations/looker/tools/looker-agent.md

github-actions · 2026-03-31T17:51:23Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

github-actions · 2026-04-01T15:49:40Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2830/

drstrangelooker · 2026-04-01T16:22:40Z

@hiracky16

Got this feedback...

This new tool doesn't align well with our Style Guide https://mcp-toolbox.dev/reference/style-guide/. Not blocking, but take a look

Mixing Read and Write Operations

The most significant violation is the combination of list, get, create, update, and delete operations into a single tool via an operation parameter.

Style Guide Rule: "Never mix read and write logic in a single function. This enables clear consent models where users can auto-approve low-risk reads but must manually approve destructive writes" (source).

Recommendation: Split the tool into separate tools: list_agents, get_agent, create_agent, update_agent, and delete_agent.

Parameter Count and Complexity

The current tool defines 6 parameters (operation, agent_id, name, instructions, sources, code_interpreter) (source).

Style Guide Rule: "Aim for fewer than 5 parameters per tool" (source).

Recommendation: Splitting the tool into specific actions (as suggested in point 1) will naturally reduce the parameter count for each tool to a more manageable number (e.g., delete_agent would only need 1 parameter).

duwenxin99 · 2026-04-01T16:34:30Z

🚀 Cloudflare Preview Ready!

🔎 View Preview: https://pr-2830.toolbox-docs-6xc.pages.dev

(Note: Subsequent pushes to this PR will automatically update the preview at this same URL)

The old doc workflow is deprecated. The doc changes can be previewed in the Cloudfare link. It will be auto-updated with the "deploy doc preview" label.

drstrangelooker · 2026-04-01T17:42:46Z

@hiracky16 I refactored this into 5 tools and set the annotations. Can you take a look and test everything in your environment?

…date-agent

hiracky16 · 2026-04-02T00:20:29Z

@drstrangelooker
LGTM!
Thank you for the feedback and the refactoring.
The changes look great and make the code much cleaner.

duwenxin99 · 2026-04-02T14:43:37Z

internal/tools/looker/lookercreateagent/lookercreateagent.go

+	codeInterpreterParameter := parameters.NewBooleanParameterWithDefault("code_interpreter", false, "Optional. Enables Code Interpreter for this Agent.")
+	params := parameters.Parameters{nameParameter, instructionsParameter, sourcesParameter, codeInterpreterParameter}
+
+	annotations := cfg.Annotations


I think we shouldn't allow the Toolbox user to overwrite the readOnly annotation for this tool, because it will never be readOnly. If the Toolbox user mis-configure it to be not read-only, it will mislead the client to allow the LLM to execute this tool without end-user approval. Should we fetch the user annotations first, and append readOnly on top of that?

duwenxin99 · 2026-04-02T14:44:31Z

internal/tools/looker/lookerdeleteagent/lookerdeleteagent.go

+	params := parameters.Parameters{agentIdParameter}
+
+	annotations := cfg.Annotations
+	if annotations == nil {


Same for this tool - we should make sure the readOnly and destructive annotations cannot be overwritten.

duwenxin99 · 2026-04-02T14:44:40Z

internal/tools/looker/lookerupdateagent/lookerupdateagent.go

+
+	annotations := cfg.Annotations
+	if annotations == nil {
+		readOnlyHint := false


duwenxin99 · 2026-04-02T14:57:16Z

go.mod


 go 1.25.7

-toolchain go1.26.1


hiracky16 added 4 commits March 24, 2026 15:12

feat(tools/looker): add looker-agent tool

33e0a57

fix(tools/looker): address copilot review feedback

089ad98

fix(tools/looker): update error status codes to 400 for client errors

afd8cde

docs(tools/looker): remove duplicate documentation file

5df7717

drstrangelooker requested review from a team as code owners March 24, 2026 19:14

blunderbuss-gcf bot assigned Yuan325 Mar 24, 2026

drstrangelooker added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 24, 2026

gemini-code-assist bot reviewed Mar 24, 2026

View reviewed changes

fix(tools/looker): Minor fixes to docs and lookeragent.go

bdf0205

drstrangelooker commented Mar 24, 2026

View reviewed changes

docs/en/resources/tools/looker/looker-agent.md Outdated Show resolved Hide resolved

drstrangelooker mentioned this pull request Mar 24, 2026

feat(tools/looker): add looker-agent tool #2827

Closed

6 tasks

This was referenced Mar 24, 2026

feat(tools/looker): address feedback for looker-agent tool hiracky16/genai-toolbox#5

Merged

fix(tools/looker): address feedback for agent tool #2834

Merged

hiracky16 and others added 2 commits March 25, 2026 10:21

fix(tools/looker): address feedback for agent tool (#2834)

8905e5b

## Description Addresses the feedback from the maintainers regarding the `looker-agent` tool.

Merge remote-tracking branch 'origin/main' into looker-agent

e2c5ced

hiracky16 mentioned this pull request Mar 29, 2026

fix(tools/looker): address CI failures and enhance agent tool functionality #2887

Merged

6 tasks

hiracky16 and others added 2 commits March 30, 2026 15:14

Merge branch 'main' into looker-agent

a93cb6b

dishaprakash reviewed Mar 31, 2026

View reviewed changes

docs/en/integrations/looker/tools/looker-agent.md Outdated Show resolved Hide resolved

drstrangelooker added 2 commits March 31, 2026 13:40

Merge remote-tracking branch 'origin/main' into looker-agent

88926dc

docs: remove aliases from looker-agent.md

12f5de2

drstrangelooker force-pushed the looker-agent branch from 20e68e0 to 12f5de2 Compare March 31, 2026 17:44

Merge branch 'main' into looker-agent

8887deb

duwenxin99 added the docs: deploy-preview Label to trigger Github Action docs preview. label Apr 1, 2026

Merge branch 'main' into looker-agent

8ef8780

github-actions bot removed the docs: deploy-preview Label to trigger Github Action docs preview. label Apr 1, 2026

Merge branch 'main' into looker-agent

e1e295f

drstrangelooker added the docs: deploy-preview Label to trigger Github Action docs preview. label Apr 1, 2026

github-actions bot removed the docs: deploy-preview Label to trigger Github Action docs preview. label Apr 1, 2026

drstrangelooker added 2 commits April 1, 2026 13:12

Merge remote-tracking branch 'origin/main' into looker-agent

5b35207

feat(tools/looker): refactor into five tools

b487ff3

fix(tool/looker): fix tests

a05e0e8

drstrangelooker added the docs: deploy-preview Label to trigger Github Action docs preview. label Apr 1, 2026

github-actions bot removed the docs: deploy-preview Label to trigger Github Action docs preview. label Apr 1, 2026

drstrangelooker added 2 commits April 1, 2026 14:28

Merge remote-tracking branch 'origin/main' into looker-agent

0f1314a

fix(tools/looker): refine datatypes and tests for create-agent and up…

0d100d2

…date-agent

drstrangelooker force-pushed the looker-agent branch from 7845c92 to 0d100d2 Compare April 1, 2026 19:47

docs(tools/looker): updated docs for the looker agent management tools.

5fd2693

duwenxin99 requested changes Apr 2, 2026

View reviewed changes

Conversation

drstrangelooker commented Mar 24, 2026

Description

PR Checklist

Uh oh!

gemini-code-assist bot commented Mar 24, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

drstrangelooker commented Mar 24, 2026

Uh oh!

drstrangelooker commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

drstrangelooker commented Mar 24, 2026

Uh oh!

hiracky16 commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

hiracky16 commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

drstrangelooker commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

drstrangelooker commented Apr 1, 2026

Uh oh!

duwenxin99 commented Apr 1, 2026

Uh oh!

drstrangelooker commented Apr 1, 2026

Uh oh!

hiracky16 commented Apr 2, 2026

Uh oh!

duwenxin99 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

duwenxin99 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

duwenxin99 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

duwenxin99 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hiracky16 commented Mar 29, 2026 •

edited

Loading