fix(tools/looker): address CI failures and enhance agent tool functionality#2887
Merged
drstrangelooker merged 2 commits intogoogleapis:looker-agentfrom Mar 30, 2026
Merged
Conversation
…ort agent instructions/update
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the documentation for the Looker agent's sources parameter and refactors lookeragent_test.go by shortening error message expectations, reformatting mock methods, and removing trailing whitespace. Feedback was provided to enhance the documentation by including specific details about the expected JSON keys ('model' and 'explore') for data sources, as the current change reduced the informativeness of the description.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
6 tasks
drstrangelooker
approved these changes
Mar 30, 2026
Contributor
|
/gcbrun |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ort agent instructions/update
Description
This PR addresses CI failures observed in #2830 and enhances the
looker-agenttool with missing functionality and improved robustness.Based on the CI results in #2830, I have fixed the linting issues and the documentation build error. I have also taken this opportunity to implement essential missing features such as agent instructions and update operations.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>