Skip to content

fix(tools/looker): address CI failures and enhance agent tool functionality#2887

Merged
drstrangelooker merged 2 commits intogoogleapis:looker-agentfrom
hiracky16:fix/looker-agent-upstream
Mar 30, 2026
Merged

fix(tools/looker): address CI failures and enhance agent tool functionality#2887
drstrangelooker merged 2 commits intogoogleapis:looker-agentfrom
hiracky16:fix/looker-agent-upstream

Conversation

@hiracky16
Copy link
Copy Markdown
Contributor

…ort agent instructions/update

Description

This PR addresses CI failures observed in #2830 and enhances the looker-agent tool with missing functionality and improved robustness.

Based on the CI results in #2830, I have fixed the linting issues and the documentation build error. I have also taken this opportunity to implement essential missing features such as agent instructions and update operations.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@hiracky16 hiracky16 requested review from a team as code owners March 29, 2026 22:03
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the documentation for the Looker agent's sources parameter and refactors lookeragent_test.go by shortening error message expectations, reformatting mock methods, and removing trailing whitespace. Feedback was provided to enhance the documentation by including specific details about the expected JSON keys ('model' and 'explore') for data sources, as the current change reduced the informativeness of the description.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@drstrangelooker
Copy link
Copy Markdown
Contributor

/gcbrun

@github-actions
Copy link
Copy Markdown
Contributor

@drstrangelooker drstrangelooker merged commit 1c9944a into googleapis:looker-agent Mar 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants