chore(ci): fix presubmit script exit codes#14230
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request attempts to fix exit code handling in the presubmit script and re-enables a test. While re-enabling the test is fine, the fix for the gotestsum exit code is incorrect as it captures the exit code from tee due to the pipe. I've left a critical comment suggesting the use of PIPESTATUS to correctly capture the exit code. The comment also details a more significant issue with the gotestsum command being malformed and provides a complete fix for the command block to ensure the CI script works as expected.
westarle
force-pushed
the
fix-presubmit-exit-codes
branch
from
March 22, 2026 03:34
5209705 to
bdf4e37
Compare
Fixes the presubmit script to capture gotestsum exit codes correctly so that test failures are actually reported by Kokoro.
westarle
force-pushed
the
fix-presubmit-exit-codes
branch
from
March 22, 2026 03:40
bdf4e37 to
3902f71
Compare
westarle
marked this pull request as ready for review
March 22, 2026 03:54
westarle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presubmits aren't currently reporting test errors. This fixes the presubmit script to capture gotestsum exit codes correctly so that test failures are reported by Kokoro on presubmits.