Skip to content

chore(ci): fix presubmit script exit codes #14230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shollyman merged 1 commit into from
Mar 23, 2026
Merged

chore(ci): fix presubmit script exit codes #14230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions internal/kokoro/presubmit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,18 @@ runPresubmitTests() {
--junitfile sponge_log.xml \
--format standard-verbose \
-- "${go_test_args[@]}" 2>&1 | tee sponge_log.log
exit_code=$(($exit_code + ${PIPESTATUS[0]}))

# Run integration tests against an emulator.
if [ -f "emulator_test.sh" ]; then
./emulator_test.sh
exit_code=$(($exit_code + $?))
fi
# Add the exit codes together so we exit non-zero if any module fails.
exit_code=$(($exit_code + $?))

if [[ $PWD != *"/internal/"* ]]; then
go build ./...
exit_code=$(($exit_code + $?))
fi
exit_code=$(($exit_code + $?))
}

SIGNIFICANT_CHANGES=$(git --no-pager diff --name-only origin/$KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH_google_cloud_go...$KOKORO_GIT_COMMIT_google_cloud_go |
Expand Down
Loading