chore(deps): update pip to v1 (major)#2881
chore(deps): update pip to v1 (major)#2881renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
/gcbrun |
trusted-contributions-gcf
bot
added
the
tests: run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the toolbox-core dependency to version 1.0.0 in the Python core quickstart requirements. Feedback highlights that this major version bump could break the quickstart.py example because it relies on hardcoded tool indices; refactoring the example to dispatch tools by name is recommended to improve robustness against library updates.
| @@ -1,3 +1,3 @@ | |||
| google-genai==1.67.0 | |||
| toolbox-core==0.6.0 | |||
| toolbox-core==1.0.0 | |||
There was a problem hiding this comment.
This major version bump from 0.6.0 to 1.0.0 introduces a significant risk of breaking the associated quickstart.py example. The example code is fragile as it relies on a hardcoded index to call tools (e.g., toolbox_tools[3]), which assumes a specific, stable alphabetical order from the library.
A major version update could easily alter this tool ordering, which would break the example. This implementation is not robust and sets a poor precedent for users.
To improve maintainability and provide a better example, quickstart.py should be refactored to dispatch tools by name rather than by index.
Here is a more robust approach:
# In quickstart.py, after loading tools:
tool_map = {tool.__name__: tool for tool in toolbox_tools}
# Then, when dispatching a function call:
if fn_name in tool_map:
function_result = await tool_map[fn_name](**function_call.args)
else:
raise ValueError(f"Function name {fn_name} not present.")This change would make the quickstart resilient to ordering changes in future library updates.
renovate-bot
force-pushed
the
renovate/major-pip
branch
from
c3ee058 to
1c94a84
Compare
renovate-bot
changed the title
|
/gcbrun |
Yuan325
added
the
priority: p1
anubhav756
force-pushed
the
renovate/major-pip
branch
from
1c94a84 to
3fe6102
Compare
|
/gcbrun |
|
🚀 Cloudflare Preview Ready! 🔎 View Preview: https://pr-2881.toolbox-docs-6xc.pages.dev (Note: Subsequent pushes to this PR will automatically update the preview at this same URL) |
Yuan325
added
the
do not merge
|
A separete PR was made for this update: #2863 |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
5 participants
This PR contains the following updates:
==0.7.0→==1.0.0==0.6.0→==1.0.0==0.6.0→==1.0.0Release Notes
googleapis/mcp-toolbox-sdk-python (toolbox-adk)
v1.0.0: toolbox-langchain: v1.0.0Compare Source
Features
Bug Fixes
Documentation
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.