Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
google-adk[toolbox]==1.27.2
toolbox-adk==0.7.0
toolbox-adk==1.0.0
google-genai==1.67.0
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
langchain==1.2.12
langchain-google-vertexai==3.2.2
toolbox-langchain==0.6.0
toolbox-langchain==1.0.0
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
google-genai==1.67.0
toolbox-core==0.6.0
toolbox-core==1.0.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This major version bump from 0.6.0 to 1.0.0 introduces a significant risk of breaking the associated quickstart.py example. The example code is fragile as it relies on a hardcoded index to call tools (e.g., toolbox_tools[3]), which assumes a specific, stable alphabetical order from the library.

A major version update could easily alter this tool ordering, which would break the example. This implementation is not robust and sets a poor precedent for users.

To improve maintainability and provide a better example, quickstart.py should be refactored to dispatch tools by name rather than by index.

Here is a more robust approach:

# In quickstart.py, after loading tools:
tool_map = {tool.__name__: tool for tool in toolbox_tools}

# Then, when dispatching a function call:
if fn_name in tool_map:
    function_result = await tool_map[fn_name](**function_call.args)
else:
    raise ValueError(f"Function name {fn_name} not present.")

This change would make the quickstart resilient to ordering changes in future library updates.

pytest==9.0.2
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
langchain==1.2.12
langchain-google-vertexai==3.2.2
langgraph==1.1.2
toolbox-langchain==0.6.0
toolbox-langchain==1.0.0
pytest==9.0.2