Skip to content

fix(tools/looker): refactor looker-git-branch tool into 5 separate tools#2976

Open
drstrangelooker wants to merge 1 commit intomainfrom
looker-git-branch
Open

fix(tools/looker): refactor looker-git-branch tool into 5 separate tools#2976
drstrangelooker wants to merge 1 commit intomainfrom
looker-git-branch

Conversation

@drstrangelooker
Copy link
Copy Markdown
Contributor

Description

refactor looker-git-branch tool into 5 separate tools with proper annotations to isolate readonly and destructive tool actions

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

@drstrangelooker drstrangelooker requested review from a team as code owners April 7, 2026 21:31
@drstrangelooker
Copy link
Copy Markdown
Contributor Author

got this feedback on another tool -

This new tool doesn't align well with our Style Guide https://mcp-toolbox.dev/reference/style-guide/. Not blocking, but take a look

Mixing Read and Write Operations
The most significant violation is the combination of list, get, create, update, and delete operations into a single tool > via an operation parameter.

Style Guide Rule: "Never mix read and write logic in a single function. This enables clear consent models where users can auto-approve low-risk reads but must manually approve destructive writes" (source).

This change addresses the same problem with this tool.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors Looker git branch management by splitting the monolithic project_git_branch tool into five specialized tools: list_git_branches, get_git_branch, create_git_branch, switch_git_branch, and delete_git_branch. The changes include new Go implementations, updated documentation, and revised integration tests. Feedback was provided to correct the copyright year in several new files, which is currently set to 2026.

…ols with proper annotations to isolate readonly and destructive tool actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants