Fix Accessibility on Background Containers #2282
Open
+1,549
−2,874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: react 18 types * fix: allow providing whatever version of react types the library consumer needs as optional peer dependecies
…hom#1335)(by @eps1lon) * fix(BottomSheetScrollView): Scroll responder types use mixin * chore: removed unused import --------- Co-authored-by: gorhom <[email protected]>
…(by @janicduplessis) * Fix reanimated freezing Keyboard module
* fix: crash on swipe down * fix: keyboard dismiss on JS thread * fix: call the keyboard dismiss method --------- Co-authored-by: Mo Gorhom <[email protected]>
@beqramo) * fix: keyboard on focus * fix: updated containerOffset top value to default to 0 --------- Co-authored-by: Mo Gorhom <[email protected]>
* feat: added dynamic sizing * chore: updated dynamic sizing example * chore: removed commented code * chore: added deprecated tag to useBottomSheetDynamicSnapPoints * chore: added extra description for snap points prop
* fix(bottomSheet): snapPoints type * fix(bottomSheet): fix lint
Release 5.0.0-alpha.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state, the screenreader is always focusing containers on its way down to the contents of the bottomsheet.
this is (possibly) not the wanted behavior, so we changed it.