Skip to content

Fix Accessibility on Background Containers #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d41eda2
chore: fixed types (#1123)(by @stropho)
stropho Apr 30, 2023
9c5af58
fix(BottomSheetScrollView): updated scroll responders props type (#13…
eps1lon Apr 30, 2023
94cf11e
fix: fixed keyboard dismissing issue with Reanimated v3 (#1346)(by @j…
gorhom Apr 30, 2023
2e558d1
chore: release v4.4.6
gorhom Apr 30, 2023
235466f
fix: crash on swipe down (#1367)(by @beqramo)
beqramo Jun 4, 2023
92ad842
fix: resume close animation when container gets resized (#1374) (#1392)
gorhom Jun 4, 2023
f25cec2
chore: release v4.4.7
gorhom Jun 4, 2023
ea03e78
fix: updated scrollables mocks with ReactNative list equivalent (#139…
gkueny Jun 23, 2023
1ecad69
fix(bottom-sheet-modal): added container component prop to modal (#13…
magrinj Jun 23, 2023
218e006
fix: updated containerOffset top value to default to 0 (#1420)(by @be…
beqramo Jul 15, 2023
6a5034c
fix(BottomSheetTextInput): reset shouldHandleKeyboardEvents on unmoun…
koplyarov Sep 6, 2023
43de6d7
chore: release v4.4.8
gorhom Sep 6, 2023
7330c7c
feat: added dynamic sizing (#1513)(with @Eli-Nathan & @ororsatti)
gorhom Sep 10, 2023
0b1c8cc
fix: updated snapPoint prop type (#1479)(by @nicolascavallin)
nicolascavallin Sep 10, 2023
08eec82
chore: release v4.5.0
gorhom Sep 10, 2023
6fc2cd1
fix: dismiss all action for modals (#1529)(by @david-gomes5)
david-gomes5 Sep 17, 2023
9564467
chore: updated snap points normalisation hook deps
gorhom Sep 11, 2023
af53c28
fix: allowed content max height be applied for dynamic sizing
gorhom Sep 17, 2023
55c9857
chore: updated detached modal example
gorhom Sep 17, 2023
fef9925
chore: update dev dependencies
gorhom Sep 17, 2023
65b5dc0
chore: release v4.5.1
gorhom Sep 17, 2023
ed8ce04
Add: accessibility port
liviu-padurariu Dec 21, 2023
77eec12
Fix: accessibility
liviu-padurariu Dec 22, 2023
e016f57
Mod: version bump
liviu-padurariu Dec 22, 2023
82caed5
Merge
liviu-padurariu Dec 29, 2023
14c1696
Mod: version bump
liviu-padurariu Dec 29, 2023
0d54880
Merge tag 'v5.0.0-alpha.6'
liviu-padurariu Jan 19, 2024
e2c263b
Merge remote-tracking branch 'github/master'
braandl May 9, 2025
48d1347
Mod: Updated Lockfile
braandl May 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/bottomSheet/BottomSheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1919,8 +1919,11 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
backgroundStyle={_providedBackgroundStyle}
/>
<Animated.View
pointerEvents="box-none"
// pointerEvents="box-none"
style={contentMaskContainerStyle}
accessible={false}
// accessibilityRole={_providedAccessibilityRole ?? undefined}
// accessibilityLabel={_providedAccessibilityLabel ?? undefined}
accessible={_providedAccessible ?? undefined}
accessibilityRole={_providedAccessibilityRole ?? undefined}
accessibilityLabel={_providedAccessibilityLabel ?? undefined}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const BottomSheetBackgroundComponent = ({
}: BottomSheetBackgroundProps) => (
<View
pointerEvents={pointerEvents}
accessible={true}
accessible={false}
accessibilityRole="adjustable"
accessibilityLabel="Bottom Sheet"
style={[styles.container, style]}
Expand Down
2 changes: 1 addition & 1 deletion src/components/bottomSheetFooter/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ export interface BottomSheetDefaultFooterProps extends BottomSheetFooterProps {
*
* @type {ReactNode|ReactNode[]}
*/
children?: ReactNode | ReactNode[];
children?: ReactNode | ReactNode[] | (() => ReactElement);
}
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,12 @@ function BottomSheetHandleContainerComponent({
<GestureDetector gesture={panGesture}>
<Animated.View
key="BottomSheetHandleContainer"
accessible={false}
importantForAccessibility={"no"}
accessibilityRole="adjustable"
accessibilityLabel="Bottom Sheet handle"
accessibilityHint="Drag up or down to extend or minimize the Bottom Sheet"
style={styles.container}
onLayout={handleContainerLayout}
style={styles.container}
>
Expand Down
7 changes: 7 additions & 0 deletions src/components/bottomSheetTextInput/BottomSheetTextInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ const BottomSheetTextInputComponent = forwardRef<
>(({ onFocus, onBlur, ...rest }, ref) => {
//#region hooks
const { shouldHandleKeyboardEvents } = useBottomSheetInternal();

useEffect(() => {
return () => {
// Reset the flag on unmount
shouldHandleKeyboardEvents.value = false;
};
}, [shouldHandleKeyboardEvents]);
//#endregion

//#region callbacks
Expand Down
Loading