Skip to content

Add Welsh translation page#2298

Merged
DavidBiddle merged 6 commits into
mainfrom
add-welsh-translation-page
Oct 28, 2025
Merged

Add Welsh translation page#2298
DavidBiddle merged 6 commits into
mainfrom
add-welsh-translation-page

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Oct 24, 2025 •
edited
Loading

What problem does this pull request solve?

Trello card: https://trello.com/c/tQCcRdwS/2638-add-new-page-for-adding-welsh-translations

Adds a new page for adding Welsh translations. At the moment it's just the page with a mark complete component on it:

image

There's a validation message if the user manages to leave the radio button blank (which shouldn't happen by default, because 'No' is the default):

image

There are different success messages depending on whether the user marked the task complete:
image
image

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle force-pushed the add-welsh-translation-page branch 2 times, most recently from 52f2afe to 173e101 Compare October 27, 2025 09:04
@DavidBiddle DavidBiddle changed the title Add welsh translation page Add Welsh translation page Oct 27, 2025
@DavidBiddle DavidBiddle force-pushed the add-welsh-translation-page branch from 173e101 to 6e52401 Compare October 27, 2025 11:32
@DavidBiddle DavidBiddle marked this pull request as ready for review October 27, 2025 11:55
@chao-xian
Copy link
Copy Markdown
Contributor

chao-xian commented Oct 27, 2025

Looks good! Will check again when you've rebased?

@DavidBiddle DavidBiddle force-pushed the add-welsh-translation-page branch from 6e52401 to 482b10c Compare October 27, 2025 16:20
chao-xian
chao-xian reviewed Oct 27, 2025
View reviewed changes
Comment thread app/controllers/forms/welsh_translation_controller.rb
chao-xian
chao-xian previously approved these changes Oct 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@chao-xian chao-xian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we now have an unused controller from my previous PR but we can either rename or just delete it separately

@DavidBiddle DavidBiddle force-pushed the add-welsh-translation-page branch from 482b10c to 8103218 Compare October 27, 2025 16:38
@DavidBiddle
Add actions for Welsh translation page
f0f2db5 
Adds placeholder actions for adding Welsh translations to forms.

Also updates the path helper from `/translations` to `welsh-translation`
and renames the controller to WelshTranslationController.
@DavidBiddle
Create input object for Welsh translation page
ac21b6a 
Adds a new input object for the Welsh translation page, which will
handle translations in the future but currently just controls whether
the task has been completed.
@DavidBiddle
Add form to welsh translation page
c9dc70b 
Adds a form to the new welsh translation page using the input object
from the previous commit and including the mark complete component.
@DavidBiddle
Add validation for blank form
967a4db 
Add a validation message if the user doesn't select a radio button. This
shouldn't normally happen anyway - 'No' will be selected by default for
a new form - but we cover it anyway.
@DavidBiddle
Add success message for Welsh translation
fdabf67 
Adds success messages when the Welsh translation is saved, with
different text depending on whether the task has been marked complete.
@DavidBiddle
Add redirect if feature flag isn't enabled
6a74afe 
Hides the page behind the `welsh_enabled` feature flag - if the form is
in a group without the flag enabled, the user will be redirected to the
task list if they try to access this page.
@DavidBiddle DavidBiddle force-pushed the add-welsh-translation-page branch from 8103218 to 6a74afe Compare October 28, 2025 10:15
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 28, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 28, 2025

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2298.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@william-castoncook william-castoncook self-requested a review October 28, 2025 11:05
william-castoncook
william-castoncook approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@william-castoncook william-castoncook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots look as expected.

@DavidBiddle DavidBiddle merged commit 51841b5 into main Oct 28, 2025
6 checks passed
@DavidBiddle DavidBiddle deleted the add-welsh-translation-page branch October 28, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chao-xian chao-xian chao-xian approved these changes

@william-castoncook william-castoncook william-castoncook approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidBiddle @chao-xian @william-castoncook