This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Prepare next_page column in pages table to be removed#791
Merged
Conversation
theseanything
previously approved these changes
Jul 9, 2025
This column hasn't been used since before we migrated from grape (see PR #116), when we migrated to grape we switched to using the acts_as_list gem and the position column instead (see commit e8cc03). Let's remove this column now.
lfdebrux
force-pushed
the
ldeb-remove-next-page-from-pages
branch
from
3fc7b34 to
619da6a
Compare
|
lfdebrux
added a commit
to govuk-forms/forms-admin
that referenced
this pull request
Jul 9, 2025
It turns out we don't need this column so we're removing it from the database from forms-api (see PR govuk-forms/forms-api#791), let's remove it from here as well.
Contributor
|
@lfdebrux how come we're adding in tests that expect next_page to not be nil? |
Contributor
Author
So it's a bit confusing, but we do still rely on the |
theseanything
approved these changes
Jul 9, 2025
lfdebrux
added a commit
to govuk-forms/forms-admin
that referenced
this pull request
Jul 9, 2025
It turns out we don't need this column so we're removing it from the database from forms-api (see PR govuk-forms/forms-api#791), let's remove it from here as well.
lfdebrux
added a commit
to govuk-forms/forms-admin
that referenced
this pull request
Jul 9, 2025
It turns out we don't need this column so we're removing it from the database from forms-api (see PR govuk-forms/forms-api#791), let's remove it from here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
While working on migrating the forms models from forms-api to forms-admin I noticed that the next_page column for a page in the forms-api database is always set to nil.
As far as I can tell this column hasn't been used since before we migrated from grape (see PR #116), when we migrated to grape we switched to using the acts_as_list gem and the position column instead (see commit e8cc03).
I think we should remove this column now.
Things to consider when reviewing