[loki] Add cooldownPeriod to defaults.kedaAutoscaling#322
Open
QuentinBisson wants to merge 3 commits intomainfrom
Open
[loki] Add cooldownPeriod to defaults.kedaAutoscaling#322QuentinBisson wants to merge 3 commits intomainfrom
QuentinBisson wants to merge 3 commits intomainfrom
Conversation
cooldownPeriod was not included in defaults.kedaAutoscaling, meaning it could not be overridden globally like pollingInterval. Add it with the same default of 300s and use coalesce in _keda.tpl so users can set a single value in defaults.kedaAutoscaling.cooldownPeriod to apply across all components instead of overriding each component individually. Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com>
Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com>
Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com>
jkroepke
reviewed
Apr 10, 2026
| # -- Interval (seconds) to poll each trigger. Overridable per component. | ||
| pollingInterval: 30 | ||
| # -- Period (seconds) to wait after the last trigger reported active before scaling back to 0. Overridable per component. | ||
| cooldownPeriod: 300 |
Member
There was a problem hiding this comment.
Q: is there an use case to set cooldownPeriod: 0
Author
There was a problem hiding this comment.
To 0, apart from immédiate downscaling, not that I think of, but being able to change it makes sense. :)
Member
There was a problem hiding this comment.
I'm asking here, if $component.kedaAutoscaling.cooldownPeriod is 0 (e.g. "empty"), then .Values.defaults.kedaAutoscaling.cooldownPeriod would be used. Thas why I use kindIs so often to check is the value is nun numeric, e.g. null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
cooldownPeriodto the shareddefaults.kedaAutoscalingblock and usecoalescein_keda.tpl, consistent with howpollingIntervalalready works.Why
pollingIntervalcan be set once indefaults.kedaAutoscaling.pollingIntervalto apply globally across all KEDA-enabled components.cooldownPerioddid not have this — it was hardcoded at 300s per component with no way to override globally. A user wanting to change the cooldown period had to repeat the override for every component individually.Change
values.yaml— add todefaults.kedaAutoscaling:_keda.tpl— use coalesce to fall back to the shared default:No behaviour change for existing deployments — per-component defaults remain 300s and take precedence over the shared default.
Signed-off-by: Quentin Bisson quentin.bisson@gmail.com