Skip to content

[loki] Add cooldownPeriod to defaults.kedaAutoscaling #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuentinBisson wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Open

[loki] Add cooldownPeriod to defaults.kedaAutoscaling #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1cbe6e
fix(loki): add cooldownPeriod to defaults.kedaAutoscaling
QuentinBisson Apr 10, 2026
2e35049
Bump Loki chart version from 11.4.6 to 11.4.8
QuentinBisson Apr 10, 2026
d3e55da
Merge branch 'main' into fix/keda-cooldown-global-default
QuentinBisson Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/loki/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Helm chart for Grafana Loki supporting monolithic, simple scalable,
type: application
# renovate: docker=docker.io/grafana/loki
appVersion: 3.7.1
version: 11.4.7
version: 11.4.8
kubeVersion: ">=1.25.0-0"
home: https://grafana-community.github.io/helm-charts
sources:
Expand Down
2 changes: 1 addition & 1 deletion charts/loki/templates/_keda.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ spec:
minReplicaCount: {{ $component.kedaAutoscaling.minReplicas }}
maxReplicaCount: {{ $component.kedaAutoscaling.maxReplicas }}
pollingInterval: {{ coalesce $component.kedaAutoscaling.pollingInterval .Values.defaults.kedaAutoscaling.pollingInterval }}
cooldownPeriod: {{ $component.kedaAutoscaling.cooldownPeriod }}
cooldownPeriod: {{ coalesce $component.kedaAutoscaling.cooldownPeriod .Values.defaults.kedaAutoscaling.cooldownPeriod }}
{{- with $component.kedaAutoscaling.fallback }}
fallback:
{{- toYaml . | nindent 4 }}
Expand Down
2 changes: 2 additions & 0 deletions charts/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ defaults:
customHeaders: ""
# -- Interval (seconds) to poll each trigger. Overridable per component.
pollingInterval: 30
# -- Period (seconds) to wait after the last trigger reported active before scaling back to 0. Overridable per component.
cooldownPeriod: 300
Copy link
Copy Markdown
Member

@jkroepke jkroepke Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is there an use case to set cooldownPeriod: 0

Copy link
Copy Markdown
Author

@QuentinBisson QuentinBisson Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To 0, apart from immédiate downscaling, not that I think of, but being able to change it makes sense. :)

Copy link
Copy Markdown
Member

@jkroepke jkroepke Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking here, if $component.kedaAutoscaling.cooldownPeriod is 0 (e.g. "empty"), then .Values.defaults.kedaAutoscaling.cooldownPeriod would be used. Thas why I use kindIs so often to check is the value is nun numeric, e.g. null

# -- KEDA trigger authentication settings. Ref: https://keda.sh/docs/latest/concepts/authentication/
authentication:
# -- Enable TriggerAuthentication for KEDA triggers
Expand Down
Loading