feat(database_observability): Always extract traceparent in MySQL query_samples collector#6081
Open
fridgepoet wants to merge 2 commits intomainfrom
Open
feat(database_observability): Always extract traceparent in MySQL query_samples collector#6081fridgepoet wants to merge 2 commits intomainfrom
fridgepoet wants to merge 2 commits intomainfrom
Conversation
fridgepoet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
The MySQL query_samples collector is changed to extract and log the traceparent from SQL_TEXT.
Pull Request Details
In an instrumented app, middleware for a DB driver/ORM like SQLCommenter can add embed trace information to each SQL statement in a comment.
If the trace information is available in the SQL statement (SQL_TEXT), this PR makes a change so that the traceparent is extracted. It is then logged under the
traceparentlabel.Example log:
Issue(s) fixed by this Pull Request
Contributes to https://github.com/grafana/grafana-dbo11y-app/issues/2659
Notes to the Reviewer
Original work: #4196
PR Checklist