-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenes app example: Add scenes app LLM plugin integration demo example #273
base: main
Are you sure you want to change the base?
Conversation
examples/app-with-scenes/src/pages/WithDrilldown/WithDrilldown.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nmarrs thanks again for these contributions.
As a side note it would be super cool if there was a way to somehow have a single github repo for demos vs needing to duplicate changes between this repo and plugin-tools
create-plugin
templates are starting points which we try to keep fairly minimal so users don't have a ton to delete, but can still see "enough" to get started. We already get feedback that they are overly complex/cluttered.
These examples can showcase more specific functionality or be fully featured demos. A potential enhancement we are considering is to allow create-plugin to eventually also load these as templates, for example npx @grafana/create-plugin@latest --pluginType='scenesapp' --template='scenesapp-with-llm'
I think this would make a great addition to the examples repository, but can I request we split this out into its own example called something like app-with-scenes-llm
and there in the example readme indicate any particular requirements or caution over experimental APIs, i.e. https://github.com/grafana/grafana-plugin-examples/tree/main/examples/app-with-service-account.
You could then remove other sections as you see fit compared to the current app-with-scenes example, to make this more focussed.
Hey @sympatheticmoose! I think this route sounds good - I will work on splitting out this example and will re-request your review when it is ready to go. Re: |
5774eb4
to
706e659
Compare
I've gone through and updated this to be a separate example. I'm having some troubles though testing this locally as when trying to open the app plugin it gets a bad request error. This should be ready though for re-review :)
Screen.Recording.2024-06-20.at.1.50.04.PM.mov |
Update the create plugin template scenes app to include a example integrating the LLM plugin
TODO:
In meantime, with LLM plugin configured here are the demos that should be possible with these changes 🦖
As a side note it would be super cool if there was a way to somehow have a single github repo for demos vs needing to duplicate changes between this repo and
plugin-tools
😬 (i.e. see this PR with duplicate changes)basic.llm.integration.question.1.mov
basic.llm.integration.question.2.mov
advanced.llm.integration.backup.mov
Related PR: grafana/plugin-tools#873