chore(deps): bump dskit to emit trace_id pprof label - #5261
Merged
Conversation
marcsanmi
force-pushed
the
deps/dskit-trace-id
branch
from
June 16, 2026 15:10
6f7446c to
2f29087
Compare
korniltsev-grafanista
approved these changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates core dependencies to pick up grafana/dskit#1006, enabling Pyroscope self-profiling to emit a trace_id pprof label for traces↔profiles correlation, and adapts the codebase and generated docs/help outputs to the updated dependency surface.
Changes:
- Bump
github.com/grafana/dskit(and aligned deps likegrafana/memberlistand OpenTelemetry modules) to versions that includetrace_idpprof label emission. - Update all
dns.NewProvidercall sites to match the new dskit function signature. - Refresh generated CLI help and configuration reference docs to include new runtime-config HTTP client and memberlist options.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/pyroscope/modules.go | Update memberlist DNS provider construction for new dskit dns.NewProvider signature. |
| pkg/metastore/raftnode/node_bootstrap.go | Update metastore raft bootstrap DNS provider construction for new dskit signature. |
| pkg/metastore/discovery/parse.go | Update discovery DNS provider creation to new dskit signature. |
| go.mod | Bump dskit + related deps; update grafana/memberlist replace to match dskit expectations. |
| go.sum | Update dependency checksums to reflect the module upgrades. |
| docs/sources/configure-server/reference-configuration-parameters/index.md | Update generated config reference to include newly exposed options from bumped deps. |
| cmd/pyroscope/help-all.txt.tmpl | Update generated full help output to include newly exposed CLI flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dskit to pick up grafana/dskit#1006, so Pyroscope's own self-profiling emits a
trace_idpprof label for traces↔profiles correlation by trace ID. The dskit bump also requires adapting to its newdns.NewProvidersignature (3 call sites) and bumping thegrafana/memberlistreplace to match dskit's.