Skip to content

Add existingClaim support for mq #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afeiszli merged 1 commit into from
Feb 6, 2023
Merged

Add existingClaim support for mq #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions templates/mq.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ spec:
name: wait-script
- name: shared-data
persistentVolumeClaim:
{{- if not .Values.mq.existingClaim }}
Copy link
Contributor

@gw0 gw0 Mar 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously!? Did you even test this? If .Values.mq.existingClaim is non-empty, its value is not used.

Copy link

@aldiserg aldiserg Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix this in PR #35

claimName: {{ .Values.mq.existingClaim }}
{{- else }}
claimName: {{ include "netmaker.fullname" . }}-shared-data-pvc
{{- end }}
---
apiVersion: v1
kind: Service
Expand All @@ -105,6 +109,7 @@ spec:
app: {{ include "netmaker.fullname" . }}-mqtt
sessionAffinity: None
---
{{- if not .Values.mq.existingClaim }}
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
Expand All @@ -117,6 +122,7 @@ spec:
requests:
storage: {{ .Values.mq.storageSize }}
---
{{- end }}
apiVersion: v1
data:
mosquitto.conf: |
Expand Down