Add existingClaim support for mq #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afeiszli: Kindly review and update. |
afeiszli
approved these changes
Feb 6, 2023
philband
added a commit
to philband/netmaker-helm
that referenced
this pull request
Feb 7, 2023
Add introduced parameter to values.yaml
gw0
reviewed
Mar 7, 2023
| @@ -85,7 +85,11 @@ spec: | |||
| name: wait-script | |||
| - name: shared-data | |||
| persistentVolumeClaim: | |||
| {{- if not .Values.mq.existingClaim }} | |||
There was a problem hiding this comment.
Seriously!? Did you even test this? If .Values.mq.existingClaim is non-empty, its value is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for MQ existingClaim,
I was facing storage issue while working with EKS & EFS for MQ, so I came to solution where I have added support for existingClaim, now I first create EFS pvc claim and then pass this to netmaker helm charts.
mq.existingClaim = [[VALUE]]