[BUGFIX] deduplicate sql metric aliases to prevent view schema collisions (#10926)#11905
Open
TemidayoA wants to merge 2 commits into
Open
[BUGFIX] deduplicate sql metric aliases to prevent view schema collisions (#10926)#11905TemidayoA wants to merge 2 commits into
TemidayoA wants to merge 2 commits into
Conversation
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10926
Description of Changes:
This PR addresses the schema collision error (
Duplicated field name in view schema) that occurs when the SQL execution engine bundles multiple expectations evaluating the same underlying metric. Previously, the query compiler assigned identical SQL aliases to these metrics, causing strict SQL backends (like Postgres) to reject the view/subquery construction.This fix introduces a dynamic alias deduplication step within
_organize_metrics_by_domain. It tracksexisting_aliasesin the current query batch and automatically appends an incrementing suffix (e.g.,_1,_2) to any colliding metric names before attaching the.label(), allowing the SQL view to compile successfully without breaking downstream positional index mapping.invoke lint(usesruff format+ruff check)