Skip to content

[BUGFIX] deduplicate sql metric aliases to prevent view schema collisions (#10926) #11905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TemidayoA wants to merge 2 commits into
base: develop
Choose a base branch
from
+14 −3
Open

[BUGFIX] deduplicate sql metric aliases to prevent view schema collisions (#10926) #11905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5d2b69
fix: deduplicate sql metric aliases to prevent view schema collisions…
TemidayoA Jun 4, 2026
6c8957f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions great_expectations/execution_engine/sqlalchemy_execution_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,9 +1187,20 @@ def _organize_metrics_by_domain( # noqa: C901 # FIXME
)
domain_batches[domain_id]["metric_ids"].append(metric_to_resolve.id)
else:
domain_batches[domain_id]["select"].append(
metric_fn.label(metric_to_resolve.metric_name)
)
alias = metric_to_resolve.metric_name

# Prevent "Duplicated field name in view schema" SQL errors by deduplicating aliases
existing_aliases = {
col.name for col in domain_batches[domain_id]["select"] if hasattr(col, "name")
}

if alias in existing_aliases:
suffix = 1
while f"{alias}_{suffix}" in existing_aliases:
suffix += 1
alias = f"{alias}_{suffix}"

domain_batches[domain_id]["select"].append(metric_fn.label(alias))
domain_batches[domain_id]["metric_ids"].append(metric_to_resolve.id)

for domain_id in list(domain_batches.keys()):
Expand Down
Loading