Skip to content

Fix issue#670

Open
everettbu wants to merge 3 commits into
mainfrom
fix-issue
Open

Fix issue#670
everettbu wants to merge 3 commits into
mainfrom
fix-issue

Conversation

@everettbu

Copy link
Copy Markdown

Mirror of facebook/react#35977
Original author: Sarthakpanigrahi-2246


Summary

How did you test this change?

@greptile-apps

greptile-apps Bot commented Mar 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes unjustified changes to the React Compiler playground's TypeScript configuration and adds an empty file to the repository root.

  • Empty dum.js file added — An empty file with no content or purpose was added to the repo root. This appears to be accidentally committed.
  • react/experimental types removed from compiler/apps/playground/tsconfig.json — This removes type definitions for React's experimental APIs, which are needed by the playground application.
  • Monorepo exclude pattern ../../../** removed — This pattern was intentional to prevent TypeScript from resolving files outside the playground project in the monorepo. Removing it may cause build slowdowns or type errors.
  • The PR title is "Fix issue" but the description provides no motivation, no test plan, and no explanation of what issue is being fixed. None of these changes appear to fix a real issue.

Confidence Score: 1/5

  • This PR removes intentional configurations and adds an empty file — it should not be merged as-is.
  • The PR removes intentional TypeScript configuration (react/experimental types and monorepo exclude pattern) without justification, adds an empty junk file, and provides no description or test plan. All changes appear harmful or accidental rather than beneficial.
  • Both dum.js (should be removed entirely) and compiler/apps/playground/tsconfig.json (changes should be reverted) need attention.

Important Files Changed

Filename Overview
compiler/apps/playground/tsconfig.json Removes react/experimental types and the monorepo exclude pattern ../../../**, both of which are intentional configurations for the playground app within the React monorepo.
dum.js Empty file with no content or purpose, likely committed by accident. Should be removed.

Comments Outside Diff (1)

  1. dum.js, line 1 (link)

    Empty file committed to repo root
    This empty file (dum.js) appears to be accidentally committed. It has no content, no references elsewhere in the codebase, and its name suggests it was a temporary/test file. It should be removed from this PR.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: dum.js
    Line: 1
    
    Comment:
    **Empty file committed to repo root**
    This empty file (`dum.js`) appears to be accidentally committed. It has no content, no references elsewhere in the codebase, and its name suggests it was a temporary/test file. It should be removed from this PR.
    
    How can I resolve this? If you propose a fix, please make it concise.

    Fix in Claude Code Fix in Codex

Fix All in Claude Code Fix All in Codex

Last reviewed commit: eb77637

@@ -6,9 +6,6 @@
"dom.iterable",
"esnext"
],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of react/experimental types breaks type coverage
The "types": ["react/experimental"] configuration was intentionally added to provide TypeScript type definitions for React's experimental APIs (e.g., useActionState, useOptimistic, and other canary features). The React Compiler playground is specifically designed to work with these experimental APIs. Removing this will cause TypeScript to fall back to the stable React type definitions, potentially losing type coverage for experimental features used in the playground.

Suggested change
],
"types": [
"react/experimental"
],
"allowJs": true,
Prompt To Fix With AI
This is a comment left during a code review.
Path: compiler/apps/playground/tsconfig.json
Line: 8

Comment:
**Removal of `react/experimental` types breaks type coverage**
The `"types": ["react/experimental"]` configuration was intentionally added to provide TypeScript type definitions for React's experimental APIs (e.g., `useActionState`, `useOptimistic`, and other canary features). The React Compiler playground is specifically designed to work with these experimental APIs. Removing this will cause TypeScript to fall back to the stable React type definitions, potentially losing type coverage for experimental features used in the playground.

```suggestion
    "types": [
      "react/experimental"
    ],
    "allowJs": true,
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

Comment on lines 33 to 35
"exclude": [
"node_modules",
"../../../**"
"node_modules"
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of monorepo exclude pattern may cause build issues
The "../../../**" exclude pattern was intentional — the playground sits at compiler/apps/playground/ (3 levels deep in the monorepo). This pattern prevents TypeScript from accidentally resolving and type-checking files from the broader React monorepo, which could cause compilation slowdowns or spurious type errors. It should be restored.

Suggested change
"exclude": [
"node_modules",
"../../../**"
"node_modules"
]
"exclude": [
"node_modules",
"../../../**"
]
Prompt To Fix With AI
This is a comment left during a code review.
Path: compiler/apps/playground/tsconfig.json
Line: 33-35

Comment:
**Removal of monorepo exclude pattern may cause build issues**
The `"../../../**"` exclude pattern was intentional — the playground sits at `compiler/apps/playground/` (3 levels deep in the monorepo). This pattern prevents TypeScript from accidentally resolving and type-checking files from the broader React monorepo, which could cause compilation slowdowns or spurious type errors. It should be restored.

```suggestion
  "exclude": [
    "node_modules",
    "../../../**"
  ]
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant