Skip to content

Fix issue #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
everettbu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix issue #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c03798d
coopy
Jul 2, 2025
1f69bef
Merge remote-tracking branch 'upstream/main'
Mar 8, 2026
eb77637
Fix issue
Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions compiler/apps/playground/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
"dom.iterable",
"esnext"
],

@greptile-apps greptile-apps Bot Mar 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of react/experimental types breaks type coverage
The "types": ["react/experimental"] configuration was intentionally added to provide TypeScript type definitions for React's experimental APIs (e.g., useActionState, useOptimistic, and other canary features). The React Compiler playground is specifically designed to work with these experimental APIs. Removing this will cause TypeScript to fall back to the stable React type definitions, potentially losing type coverage for experimental features used in the playground.

Suggested change
],
"types": [
"react/experimental"
],
"allowJs": true,
Prompt To Fix With AI 
This is a comment left during a code review.
Path: compiler/apps/playground/tsconfig.json
Line: 8

Comment:
**Removal of `react/experimental` types breaks type coverage**
The `"types": ["react/experimental"]` configuration was intentionally added to provide TypeScript type definitions for React's experimental APIs (e.g., `useActionState`, `useOptimistic`, and other canary features). The React Compiler playground is specifically designed to work with these experimental APIs. Removing this will cause TypeScript to fall back to the stable React type definitions, potentially losing type coverage for experimental features used in the playground.

```suggestion
    "types": [
      "react/experimental"
    ],
    "allowJs": true,
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

"types": [
"react/experimental"
],
"allowJs": true,
"skipLibCheck": true,
"strict": true,
Expand All @@ -34,7 +31,6 @@
".next/types/**/*.ts"
],
"exclude": [
"node_modules",
"../../../**"
"node_modules"
]
Comment on lines 33 to 35

@greptile-apps greptile-apps Bot Mar 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of monorepo exclude pattern may cause build issues
The "../../../**" exclude pattern was intentional — the playground sits at compiler/apps/playground/ (3 levels deep in the monorepo). This pattern prevents TypeScript from accidentally resolving and type-checking files from the broader React monorepo, which could cause compilation slowdowns or spurious type errors. It should be restored.

Suggested change
"exclude": [
"node_modules",
"../../../**"
"node_modules"
]
"exclude": [
"node_modules",
"../../../**"
]
Prompt To Fix With AI 
This is a comment left during a code review.
Path: compiler/apps/playground/tsconfig.json
Line: 33-35

Comment:
**Removal of monorepo exclude pattern may cause build issues**
The `"../../../**"` exclude pattern was intentional — the playground sits at `compiler/apps/playground/` (3 levels deep in the monorepo). This pattern prevents TypeScript from accidentally resolving and type-checking files from the broader React monorepo, which could cause compilation slowdowns or spurious type errors. It should be restored.

```suggestion
  "exclude": [
    "node_modules",
    "../../../**"
  ]
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

}
Empty file added dum.js
View file
Open in desktop
Empty file.
Loading