Skip to content

fix: close dismiss dialog when progress dialog is closed#19

Merged
imnotjames merged 2 commits into
grimmory-tools:mainfrom
imnotjames:fix/17/dismiss-dialog-autoclose
May 27, 2026
Merged

fix: close dismiss dialog when progress dialog is closed#19
imnotjames merged 2 commits into
grimmory-tools:mainfrom
imnotjames:fix/17/dismiss-dialog-autoclose

Conversation

@imnotjames

@imnotjames imnotjames commented May 27, 2026

Copy link
Copy Markdown
Collaborator

when the progress dialog is closed, the dismiss callback no longer matters. this change updates the progress dialog closing to also close the dismissal dialog

fixes #17

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@imnotjames, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 38 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1d6944bd-294d-4824-9862-f53f2216d1f6

📥 Commits

Reviewing files that changed from the base of the PR and between 26d62d5 and 911d116.

📒 Files selected for processing (1)
  • grimmory.koplugin/grimmory/ui/dialog_manager.lua
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnotjames imnotjames marked this pull request as ready for review May 27, 2026 18:11
@imnotjames imnotjames merged commit 0fa14db into grimmory-tools:main May 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dismiss Dialog persists even after progress bar closes

1 participant