Skip to content

fix: close dismiss dialog when progress dialog is closed #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imnotjames merged 2 commits into from
May 27, 2026
Merged

fix: close dismiss dialog when progress dialog is closed #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e143fc
fix: close dismiss dialog when progress dialog is closed
imnotjames May 27, 2026
911d116
Merge branch 'main' into fix/17/dismiss-dialog-autoclose
imnotjames May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion grimmory.koplugin/grimmory/ui/dialog_manager.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ end

function DialogManager:showProgressDialog(title, dismiss_callback, dismiss_text)
local dialog
local confirm_dialog
local is_closing = false

if dismiss_callback ~= nil then
Expand All @@ -377,7 +378,11 @@ function DialogManager:showProgressDialog(title, dismiss_callback, dismiss_text)
return
end

local confirm_dialog = ConfirmBox:new({
if confirm_dialog then
UIManager:close(confirm_dialog)
end

confirm_dialog = ConfirmBox:new({
text = dismiss_text,
ok_callback = function()
pcall(dismiss_callback)
Expand Down Expand Up @@ -406,6 +411,11 @@ function DialogManager:showProgressDialog(title, dismiss_callback, dismiss_text)

local function close_callback()
is_closing = true

if confirm_dialog then
UIManager:close(confirm_dialog)
end

UIManager:close(dialog)
end

Expand Down
Loading