Fixed potential slack webhook setting inconsistencies #16968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user set their webhook to Slack, then later hit the
Clear & Savebutton, then later came back and re-entered their Slack settings,webhook_selectedwould not be saved asslack.This means that checks for which webhook is selected in
CheckoutableListenerwould fail since Slack wasn't "selected".This PR addresses this by
webhook_selectedtoslackwithin theSlackSettingsFormlivewire component so that future updates through that form will work as expectedwebhook_selectedtoslackif the webhook settings are empty (caused by the user clickingClear & Saveor if the user had re-added Slack settings (webhook containsslack.com) butwebhook_selectedwas not properly set toslack.fixes #16965