Skip to content

Conversation

@marcusmoore
Copy link
Collaborator

Previously, if a user set their webhook to Slack, then later hit the Clear & Save button, then later came back and re-entered their Slack settings, webhook_selected would not be saved as slack.

This means that checks for which webhook is selected in CheckoutableListener would fail since Slack wasn't "selected".

This PR addresses this by

  1. Properly resetting an empty webhook_selected to slack within the SlackSettingsForm livewire component so that future updates through that form will work as expected
  2. Adds a migration that resets webhook_selected to slack if the webhook settings are empty (caused by the user clicking Clear & Save or if the user had re-added Slack settings (webhook contains slack.com) but webhook_selected was not properly set to slack.

fixes #16965

@marcusmoore marcusmoore requested a review from snipe as a code owner May 20, 2025 19:39
@snipe snipe merged commit b6eb318 into grokability:develop May 23, 2025
6 of 8 checks passed
@marcusmoore marcusmoore deleted the bug/sc-29233 branch May 27, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants