oxcmail_parse_reply_to: fix Reply-To email-address and -name assignment #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umgfoin
force-pushed
the
PR_umgfoin_fix_reply-to-parsing
branch
3 times, most recently
from
c251888 to
72935b3
Compare
[In caa9793, ``struct ONEOFF_ENTRYID`` was changed from storing raw pointers to storing ``std::string``. This means that ``tmp_entryid.pdisplay_name = x`` now takes a copy, and that statement was happening too early. –jengelh] Fixes: gromox-3.0-76-gcaa979304 References: GXH-185 Signed-off-by: umgfoin <[email protected]>
jengelh
force-pushed
the
PR_umgfoin_fix_reply-to-parsing
branch
from
72935b3 to
72155c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONEOFF_ENTRYID tmp_entryis never assigned a validvmime:mailbox-parsedemail_addr.ONEOFF_ENTRYID::pmail_addressand-::pdisplay_name-members need to be assigned not earlier thanemail_addrreceived a valid entry byvmime:Fixes #185