Make CachingManager initializer public to allow external creation#115
Merged
vazarkevych merged 10 commits intoSep 5, 2025
Merged
Conversation
…ded default CachingManager to initializer in StrickyBucketService
|
Thanks for the PR! When is it planned to be merged? Without this changes default sticky bucketing is not working |
Collaborator
Author
|
Hi @Arideno. We will do our best to release these changes ASAP. We will contact you as soon as they are available. |
|
Hey, @vazarkevych. Can I clarify if there is any scheduled review and release date? This is quite an urgent issue for us, as we still cannot use sticky bucketing. |
|
Hey, @madhuchavva, can you have a look at this PR? As it's quite important functionality fix. Thank you! |
madhuchavva
approved these changes
Aug 29, 2025
|
Hey, @vazarkevych. Can we merge this now? 🥹 |
Collaborator
Author
|
Hi @Arideno, sure. We just need to fix conflicts and will merge that. |
…ng-cachemanager # Conflicts: # Sources/CommonMain/StickyBucket/StickyBucketService.swift
Arideno
reviewed
Aug 29, 2025
| } | ||
|
|
||
|
|
||
| guard let docData = try? JSONEncoder().encode(doc) else { return } |
There was a problem hiding this comment.
@vazarkevych I think we need to call completion(nil) in else block
Arideno
reviewed
Sep 1, 2025
| @objc public class StickyBucketService: NSObject, StickyBucketServiceProtocol { | ||
| private let prefix: String | ||
| private let localStorage: CachingLayer? | ||
| private let localStorage = CachingManager() |
added 7 commits
September 2, 2025 17:38
…o preserve sticky bucket assignments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we :