Skip to content

Make CachingManager initializer public to allow external creation #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vazarkevych merged 10 commits into from
Sep 5, 2025
Merged

Make CachingManager initializer public to allow external creation #115

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
141449f
Make CachingManager initializer public to allow external creation, ad…
Aug 8, 2025
13a9521
update
vazarkevych Aug 12, 2025
54bf3db
Merge remote-tracking branch 'origin/main' into feature/stickybucketi…
Aug 29, 2025
cbaae21
update testcases json file
Sep 2, 2025
1e2344e
fix hash tests
Sep 2, 2025
7a95cd2
add query string functionality
Sep 2, 2025
872ad94
refactor isEvalOperatorCondition function
Sep 2, 2025
4393cfb
make rule id as empty string
Sep 2, 2025
b10e25c
fix StickyBucket service init with cache key, and reuse EvalContext t…
Sep 2, 2025
3362db1
fix stickybucket refresh functionalty, add function getGBAttributes
Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/CommonMain/Caching/CachingManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import CommonCrypto
private var customCachePath: String?
private var cacheKey: String = ""

init(apiKey: String? = nil) {
public init(apiKey: String? = nil) {
super.init()
if let apiKey {
self.setCacheKey(apiKey)
Expand Down
28 changes: 8 additions & 20 deletions Sources/CommonMain/StickyBucket/StickyBucketService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,18 @@ import Foundation

@objc public class StickyBucketService: NSObject, StickyBucketServiceProtocol {
private let prefix: String
private let localStorage: CachingLayer?
private let localStorage = CachingManager()

@Arideno Arideno Sep 1, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to set cacheKey somehow?

@vazarkevych vazarkevych Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


public init(prefix: String = "gbStickyBuckets__", localStorage: CachingLayer? = nil) {
public init(prefix: String = "gbStickyBuckets__", localStoragePath: CacheDirectory = .applicationSupport) {
self.prefix = prefix
self.localStorage = localStorage
localStorage.setSystemCacheDirectory(localStoragePath)
}

public func getAssignments(attributeName: String,
attributeValue: String,
completion: @escaping (StickyAssignmentsDocument?, Error?) -> Void) {
let key = "\(attributeName)||\(attributeValue)"

guard let localStorage = localStorage else {
completion(nil, nil)
return
}

if
let data = localStorage.getContent(fileName: prefix + key),
let jsonPetitions = try? JSONDecoder().decode(StickyAssignmentsDocument.self, from: data) {
Expand All @@ -39,12 +34,9 @@ import Foundation
completion: @escaping (Error?) -> Void) {
let key = "\(doc.attributeName)||\(doc.attributeValue)"

guard let localStorage = localStorage,
let docData = try? JSONEncoder().encode(doc) else {
completion(nil)
return
}


guard let docData = try? JSONEncoder().encode(doc) else { return }

@Arideno Arideno Aug 29, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vazarkevych I think we need to call completion(nil) in else block

@vazarkevych vazarkevych Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


localStorage.saveContent(fileName: prefix + key, content: docData)
completion(nil)
}
Expand All @@ -65,12 +57,8 @@ import Foundation

private func getAssignmentsSync(attributeName: String, attributeValue: String) -> StickyAssignmentsDocument? {
let key = "\(attributeName)||\(attributeValue)"

guard let localStorage = localStorage else { return nil }

if
let data = localStorage.getContent(fileName: prefix + key),
let jsonPetitions = try? JSONDecoder().decode(StickyAssignmentsDocument.self, from: data) {

if let data = localStorage.getContent(fileName: prefix + key), let jsonPetitions = try? JSONDecoder().decode(StickyAssignmentsDocument.self, from: data) {
return jsonPetitions
}

Expand Down