Faster start times #2700

harshad1 · 2025-11-29T08:22:17Z

In this PR I have made the initialization of several components a little faster.

Having really fast launch times makes the experience of using markor nicer.

This reverts commit 6c9d6c6.

harshad1 · 2025-12-02T06:44:55Z

app/src/main/java/net/gsantner/markor/activity/openeditor/OpenFromShortcutOrWidgetActivity.java

+ * This Activity exists solely to launch activities with the correct intent
 * it is necessary as widget and shortcut intents do not respect MultipleTask etc
 */
-public class OpenFromShortcutOrWidgetActivity extends MarkorBaseActivity {


MarkorBaseActivity does some extra work here which is unnecessary

harshad1 · 2025-12-02T06:46:18Z

app/src/main/java/net/gsantner/markor/activity/DocumentActivity.java

                startLine = intent.getIntExtra(Document.EXTRA_FILE_LINE_NUMBER, -1);
            } else if (intentData != null) {
                final String line = intentData.getQueryParameter("line");
-                startLine = GsTextUtils.tryParseInt(line, -1);


Bugfix to how the start line and start in preview interact

harshad1 · 2025-12-02T06:49:31Z

app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java


    private HighlightingEditor _hlEditor;
    private WebView _webView;
+    private ViewStub _webViewStub;


The webview is the heaviest view in the document fragment. This loads it lazily when necessary

harshad1 · 2025-12-02T06:50:05Z

app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java

        _lineNumbersView.setup(_hlEditor);
        _lineNumbersView.setLineNumbersEnabled(_appSettings.getDocumentLineNumbersEnabled(_document.path));

-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP && _appSettings.getSetWebViewFulldrawing()) {


same code moved into block which is called when webview is actually required and loaded

harshad1 · 2025-12-02T06:50:37Z

app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java

+                _hlEditor.setMinHeight(height);
+            }
        });
+        _verticalScrollView.addOnLayoutChangeListener((v, left, top, right, bottom, oldLeft, oldTop, oldRight, oldBottom) -> ensureMinHeight.run());


Listening to a scrollview layout change instead of a global layout change

harshad1 · 2025-12-02T06:52:01Z

app/src/main/java/net/gsantner/markor/activity/MainActivity.java

        // Setup viewpager
-        _viewPager.setAdapter(new SectionsPagerAdapter(getSupportFragmentManager()));
-        _viewPager.setOffscreenPageLimit(4);
+        _sectionsAdapter = new SectionsPagerAdapter(getSupportFragmentManager());


When main activity is loaded we do not load not shown tabs immediately.

Instead we load them lazily.

After tabs are loaded, they are cached by the adapter

harshad1 · 2025-12-02T06:52:28Z

app/src/main/java/net/gsantner/markor/activity/MainActivity.java

    public void hideKeyboard() {
-        _cu.showSoftKeyboard(this, false, _quicknote.getEditor());
-        _cu.showSoftKeyboard(this, false, _todo.getEditor());
+        if (_quicknote != null) {


These fragments may not be loaded

harshad1 · 2025-12-02T06:53:07Z

app/src/main/java/net/gsantner/markor/format/markdown/MarkdownActionButtons.java

                        final boolean isImage = m.group(1) != null;
-                        final String link = m.group(3);
-                        return new Link(m.group(2), link == null ? null : link.trim(), isImage, start, end);
+                        final String link = GsTextUtils.decodeUrl(m.group(3));


Unrelated fix for how file links with spaces are parsed

%20 now converted to and from space more correctly

harshad1 · 2025-12-02T06:54:23Z

app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserFragment.java

+                final File sel = currentSelection.iterator().next();
+                final File file = _filesystemViewerAdapter.resolveVirtualFile(sel);
+                final String title = GsFileUtils.getFilenameWithoutExtension(sel);
+                _cu.createLauncherDesktopShortcut(getContext(), file, title);


Correctly resolving shortcuts to special folders

harshad1 · 2025-12-02T06:56:15Z

app/src/main/java/net/gsantner/opoc/util/GsFileUtils.java

        }

-        if (!dest.isFile() && GsTextUtils.endsWith(sb, File.separator)) {
+        if (GsTextUtils.endsWith(sb, File.separator)) {


trailing separator on file vs folder

harshad1 · 2025-12-02T06:56:51Z

gradle/wrapper/gradle-wrapper.properties

 #Thu Dec 02 03:48:33 CET 2021
 distributionBase=GRADLE_USER_HOME
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip


I had to update gradle to get this to work on my new laptop

harshad1 · 2025-12-02T06:57:21Z

build.gradle

+        final foldername = dir.name
+        if (foldername.startsWith('values-') && !dir.absolutePath.contains("build" + File.separator + "intermediates") && !foldername.matches(".*values-((.*[0-9])|(land)|(port)).*")) {
+            dir.eachFile { file ->
+                if (file.name.toLowerCase().endsWith(".xml") && file.getText('UTF-8').contains("<string")) {


Changes needed to get the build working

harshad1 · 2025-12-02T07:00:21Z

@gsantner This is ready for review

This reverts commit 9584150.

harshad1 · 2025-12-09T00:18:12Z

@guanglinn Would you be willing to review this?

guanglinn · 2025-12-11T01:35:49Z

@guanglinn Would you be willing to review this?

I'm willing to review it, but may provide limited suggestions based on my limited understanding of Markor and Android. 😌

harshad1 · 2025-12-11T19:54:55Z

I'm willing to review it, but may provide limited suggestions due to my limited understanding of Markor and Android. 😌

This is pretty much the only Java and Android project I work on as well. I'll take any feedback

gsantner · 2025-12-11T20:07:17Z

Thank you, I will try to find time on sunday to review

pgorod · 2026-01-05T11:55:52Z

Hi. Should this affect delays that I am experiencing such as

opening a file
opening/closing the keyboard
navigating to a chapter

Or will it affect only opening the app itself?

I ask because I was about to open an Issue about a very noticeable performance degradation when upgrading from 2.14.1 to 2.15.2 (which still does not include this PR).

My problem is with a very large markdown file (214Kb, 3717 lines, hundreds of headings). But I've always used this big file quite successfully with Markor...

Should I open the Issue or is it better to wait for this PR to come out in a release?

Thanks! I love Markor!

harshad1 · 2026-01-05T17:56:13Z

There should not have been a regression between 2.14.1 and 2.15.2.

Could you share a file and steps to reproduce? Perhaps in a ticket.

harshad1 · 2026-01-05T17:56:58Z

This PR should only affect startup times (indirectly perceived load time)

guanglinn · 2026-01-06T11:30:05Z

Hi, @harshad1

The master branch code after merging this PR will throw NullPointerException here:

Steps to reproduce:

Open a Markdown file;
Switch to view-mode;
Long press the action bar.

pgorod · 2026-01-06T13:56:26Z

Could you share a file and steps to reproduce? Perhaps in a ticket.

Done, #2716

Thanks!

gsantner · 2026-01-08T04:01:28Z

I couldn't reproduce the webview crash, but I pushed a change to master to add a check there, which should fix that for you.

Harshad Srinivasan and others added 12 commits November 24, 2025 23:47

Direct launch

e66ff2c

Better, faster app start

5305eca

Lazy loading of webview

ce30b12

Reverted to trampoline

d57b9a1

Fixed widget

2d11e1d

Scheme

7f94958

Merge branch 'tried_reverting_to_trampoline' into faster_start_times

f81e780

Removed function

b5ba7de

Use deep links rather than a trampoline

6c9d6c6

Revert "Use deep links rather than a trampoline"

fa517ad

This reverts commit 6c9d6c6.

Removed scheme

940af0d

Handling spaces and %20

d9a47f9

harshad1 changed the title ~~[WIP] Faster start times~~ Faster start times Dec 2, 2025

harshad1 commented Dec 2, 2025

View reviewed changes

Conditional animation

9584150

harshad1 commented Dec 2, 2025

View reviewed changes

harshad1 added 3 commits December 5, 2025 21:53

More conservative preview setting

1892739

Added toast

a27b4d4

Properly clearing

cb67476

harshad1 added 2 commits December 6, 2025 00:36

Revert "Conditional animation"

8abbebf

This reverts commit 9584150.

Reverted approach change

d925805

harshad1 mentioned this pull request Dec 6, 2025

More modern material UI #2703

Open

harshad1 added 2 commits December 16, 2025 21:36

Pulled in change to fix removing priority

2c89b91

Fixed issue with webview being null

4e8637d

gsantner approved these changes Dec 27, 2025

View reviewed changes

gsantner merged commit a029a82 into gsantner:master Dec 27, 2025
1 check passed

gsantner assigned harshad1 Jan 8, 2026

gsantner added the enhancement label Jan 8, 2026

gsantner added this to the Markor v2.16 milestone Jan 8, 2026

gsantner linked an issue Jan 8, 2026 that may be closed by this pull request

Performance degradation from 2.14.1 to 2.15.2 #2716

Open

4 tasks

Faster start times #2700

Faster start times #2700

Conversation

harshad1 commented Nov 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harshad1 commented Dec 2, 2025

Uh oh!

harshad1 commented Dec 9, 2025

Uh oh!

guanglinn commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshad1 commented Dec 11, 2025

Uh oh!

gsantner commented Dec 11, 2025

Uh oh!

Uh oh!

pgorod commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshad1 commented Jan 5, 2026

Uh oh!

harshad1 commented Jan 5, 2026

Uh oh!

guanglinn commented Jan 6, 2026

Uh oh!

pgorod commented Jan 6, 2026

Uh oh!

gsantner commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guanglinn commented Dec 11, 2025 •

edited

Loading

pgorod commented Jan 5, 2026 •

edited

Loading