More modern material UI #2703
More modern material UI #2703
Conversation
|
In a subsequent PR, I may add an option to make the UI colours follow the editor colours. (so fully solarized will be possible) |
|
Thank you, I will try to find time on sunday to review |
|
|
||
| <color name="accent_light">#FF9800</color> | ||
| <color name="divider_2">#3D3D3D</color> | ||
| <color name="default_link_color">#388E3C</color> |
There was a problem hiding this comment.
improvements are welcome, but please keep the primary ""Markor blue"" and accent red.
| dopt.isSearchEnabled = false; | ||
| dopt.dialogWidthDp = WindowManager.LayoutParams.WRAP_CONTENT; | ||
| dopt.dialogHeightDp = 475; | ||
| dopt.positionCallback = (result) -> { |
There was a problem hiding this comment.
@guanglinn I have addressed handling none priority mapping to a single letter here.
I do this by checking index (0 = remove)
Should be more robust with this approach
|
@gsantner This is now ready for resting and review. All feedback is appreciated. |
|
Hello @harshad1 Thank you, overall the PR is fine and a good improvement! However - in dark mode, please restore the blueish-black color at toolbar and bottom navigation. 
and in light mode, please restore
I prefer Markor to stay and not to be pure white / black / gray based UI. |
3 participants
In this PR I have adjusted the colours and some UI elements in Markor to more closely match the material guidelines.
Per @gsantner's request I have reverted to using 'primaryColor' for the light mode top bar. Material design guidelines say that dark mode should have a dark bar and I also think this looks way better so I have kept this