To-Do: Fix priority can not be removed when app language is Simplified Chinese #2704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanglinn
changed the title
guanglinn
changed the title
guanglinn
commented
Dec 15, 2025
| MarkorDialogFactory.showPriorityDialog(getActivity(), selTasks.get(0).getPriority(), (priority) -> { | ||
| setPriority(priority.length() == 1 ? priority.charAt(0) : TodoTxtTask.PRIORITY_NONE); | ||
| boolean isPriority = priority.length() == 1 && TextCasingUtils.isEnglishLetter(priority.charAt(0)); | ||
| setPriority(isPriority ? priority.charAt(0) : TodoTxtTask.PRIORITY_NONE); |
Contributor
Author
There was a problem hiding this comment.
In many languages, the length of the word None (Nichts, Aucune, なし, ...) is greater than 1.
But in Simplified Chinese, this word was translated as a Chinese character 无, which has a length of 1, so the previous logic would consider it as an letter representing priority (A, B, C, ...).
guanglinn
changed the title
Contributor
Author
|
There is a more robust solution by @harshad1. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this issue #2701 - Priority can not be removed but set to (无) on priority None is selected when application language is Simplified Chinese.