Skip to content

To-Do: Fix priority can not be removed when app language is Simplified Chinese #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guanglinn wants to merge 2 commits into from
Closed

To-Do: Fix priority can not be removed when app language is Simplified Chinese #2704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
959e84a
Fix priority can not be removed when priority None is selected under …
guanglinn Dec 15, 2025
52c94a8
Tweak
guanglinn Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtActionButtons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import net.gsantner.markor.frontend.MarkorDialogFactory;
import net.gsantner.markor.frontend.textview.TextViewUtils;
import net.gsantner.markor.model.Document;
import net.gsantner.markor.util.TextCasingUtils;
import net.gsantner.opoc.util.GsCollectionUtils;
import net.gsantner.opoc.util.GsFileUtils;
import net.gsantner.opoc.wrapper.GsCallback;
Expand Down Expand Up @@ -106,7 +107,8 @@ public boolean onActionClick(final @StringRes int action) {
}
case R.string.abid_todotxt_priority: {
MarkorDialogFactory.showPriorityDialog(getActivity(), selTasks.get(0).getPriority(), (priority) -> {
setPriority(priority.length() == 1 ? priority.charAt(0) : TodoTxtTask.PRIORITY_NONE);
boolean isPriority = priority.length() == 1 && TextCasingUtils.isEnglishLetter(priority.charAt(0));
setPriority(isPriority ? priority.charAt(0) : TodoTxtTask.PRIORITY_NONE);
Copy link
Contributor Author

@guanglinn guanglinn Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In many languages, the length of the word None (Nichts, Aucune, なし, ...) is greater than 1.
But in Simplified Chinese, this word was translated as a Chinese character 无, which has a length of 1, so the previous logic would consider it as an letter representing priority (A, B, C, ...).

});
return true;
}
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/java/net/gsantner/markor/util/TextCasingUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,8 @@ public static String capitalizeSentences(String text) { // Capitalize the first
}
return result.toString();
}

public static boolean isEnglishLetter(char ch) {
return (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z');
}
}