Skip to content

✨ Upgrade to Patternfly 6#305

Merged
carlosthe19916 merged 4 commits intoguacsec:mainfrom
carlosthe19916:pf-6
May 14, 2025
Merged

✨ Upgrade to Patternfly 6#305
carlosthe19916 merged 4 commits intoguacsec:mainfrom
carlosthe19916:pf-6

Conversation

@carlosthe19916
Copy link
Copy Markdown
Collaborator

@carlosthe19916 carlosthe19916 commented Jan 8, 2025

Doing a first experiment to see what the upgrade implies. So the only problem I saw is that the Charts lose their X Y positions in the context of the DIVs that wrap them.

UI Tests PR: 53

@trust-git-bot
Copy link
Copy Markdown

trust-git-bot commented Jan 10, 2025

🚀 Storybook Deployed Preview: https://trustify-ui-pr-305-preview.surge.sh

Copy link
Copy Markdown
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wondering why the chat-bot is included here ?

@carlosthe19916
Copy link
Copy Markdown
Collaborator Author

Looks good. Just wondering why the chat-bot is included here ?

That is my mistake. I will remove it. Sorry for that

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts:
#	client/src/app/App.css
#	client/src/app/api/model-utils.ts
#	client/src/app/client/index.ts
#	client/src/app/client/types.gen.ts
#	client/src/app/components/ConfirmDialog.tsx
#	client/src/app/components/FilterPanel/SearchFilterControl.tsx
#	client/src/app/components/FilterToolbar/DateRangeFilter.tsx
#	client/src/app/components/FilterToolbar/MultiselectFilterControl.tsx
#	client/src/app/components/FilterToolbar/SelectFilterControl.tsx
#	client/src/app/components/StateError.tsx
#	client/src/app/components/markdownPFComponents.tsx
#	client/src/app/components/notes-markdown.tsx
#	client/src/app/layout/about.tsx
#	client/src/app/layout/header.tsx
#	client/src/app/layout/sidebar.tsx
#	client/src/app/pages/advisory-details/advisory-details.tsx
#	client/src/app/pages/package-details/package-details.tsx
#	client/src/app/pages/sbom-details/sbom-details.tsx
#	client/src/app/pages/search/components/SearchMenu.tsx
#	client/src/app/pages/search/search.tsx
#	client/src/app/pages/upload/components/upload-file.tsx
#	client/src/app/pages/upload/upload.tsx
#	client/src/app/pages/vulnerability-details/vulnerability-details.tsx
#	client/src/app/utils/utils.ts
#	client/src/stories/v2.1/pages/search.tsx
#	client/src/stories/v2.1/product-list.stories.tsx
#	client/src/stories/v2.1/product-wizard.stories.tsx
#	package-lock.json
@carlosthe19916 carlosthe19916 marked this pull request as ready for review May 12, 2025 08:48
@carlosthe19916 carlosthe19916 changed the title WIP: Upgrade to Patternfly 6 ✨ Upgrade to Patternfly 6 May 12, 2025
@carlosthe19916 carlosthe19916 requested a review from gildub May 12, 2025 08:49
carlosthe19916 and others added 2 commits May 13, 2025 14:58
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look really nice. Thanks

@gildub gildub added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2025
@gildub gildub added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2025
@carlosthe19916 carlosthe19916 merged commit 0aee986 into guacsec:main May 14, 2025
9 checks passed
carlosthe19916 added a commit to trustification/trustify-tests that referenced this pull request May 14, 2025
The UI PR guacsec/trustify-ui#305
migrates the whole UI to Patternfly 6.

This PR should make sure our tests are also aligned to the migration.

We should merge this PR after the UI PR counterpart is merged

---------

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to PatternFly v6

3 participants