✨ Upgrade to Patternfly 6#305
Merged
carlosthe19916 merged 4 commits intoguacsec:mainfrom May 14, 2025
Merged
Conversation
|
🚀 Storybook Deployed Preview: https://trustify-ui-pr-305-preview.surge.sh ✨ |
gildub
reviewed
Jan 28, 2025
Contributor
gildub
left a comment
There was a problem hiding this comment.
Looks good. Just wondering why the chat-bot is included here ?
Collaborator
Author
That is my mistake. I will remove it. Sorry for that |
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts: # client/src/app/App.css # client/src/app/api/model-utils.ts # client/src/app/client/index.ts # client/src/app/client/types.gen.ts # client/src/app/components/ConfirmDialog.tsx # client/src/app/components/FilterPanel/SearchFilterControl.tsx # client/src/app/components/FilterToolbar/DateRangeFilter.tsx # client/src/app/components/FilterToolbar/MultiselectFilterControl.tsx # client/src/app/components/FilterToolbar/SelectFilterControl.tsx # client/src/app/components/StateError.tsx # client/src/app/components/markdownPFComponents.tsx # client/src/app/components/notes-markdown.tsx # client/src/app/layout/about.tsx # client/src/app/layout/header.tsx # client/src/app/layout/sidebar.tsx # client/src/app/pages/advisory-details/advisory-details.tsx # client/src/app/pages/package-details/package-details.tsx # client/src/app/pages/sbom-details/sbom-details.tsx # client/src/app/pages/search/components/SearchMenu.tsx # client/src/app/pages/search/search.tsx # client/src/app/pages/upload/components/upload-file.tsx # client/src/app/pages/upload/upload.tsx # client/src/app/pages/vulnerability-details/vulnerability-details.tsx # client/src/app/utils/utils.ts # client/src/stories/v2.1/pages/search.tsx # client/src/stories/v2.1/product-list.stories.tsx # client/src/stories/v2.1/product-wizard.stories.tsx # package-lock.json
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
carlosthe19916
added a commit
to trustification/trustify-tests
that referenced
this pull request
May 14, 2025
The UI PR guacsec/trustify-ui#305 migrates the whole UI to Patternfly 6. This PR should make sure our tests are also aligned to the migration. We should merge this PR after the UI PR counterpart is merged --------- Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing a first experiment to see what the upgrade implies. So the only problem I saw is that the Charts lose their X Y positions in the context of the DIVs that wrap them.
UI Tests PR: 53