Conversation
…5.0c1dbdea published by rtyley rtyley published release version 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-03T1555.0c1dbdea using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-03T1555.0c1dbdea Release-Initiated-By: https://github.com/rtyley Release-Workflow-Run: https://github.com/guardian/etag-caching/actions/runs/17439005303 Release-Notes: #110
|
@rtyley has published a preview version of this PR with release workflow run #242, based on commit 0c1dbde: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-03T1555.0c1dbdea Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the support-fetching-then-parsing-with-key branch, or use the GitHub CLI command: gh workflow run release.yml --ref support-fetching-then-parsing-with-key Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
0c1dbde to
32fe2e2
Compare
…4.32fe2e20 published by rtyley rtyley published release version 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-04T1544.32fe2e20 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-04T1544.32fe2e20 Release-Initiated-By: https://github.com/rtyley Release-Workflow-Run: https://github.com/guardian/etag-caching/actions/runs/17469345493 Release-Notes: #110
|
@rtyley has published a preview version of this PR with release workflow run #244, based on commit 32fe2e2: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-04T1544.32fe2e20 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the support-fetching-then-parsing-with-key branch, or use the GitHub CLI command: gh workflow run release.yml --ref support-fetching-then-parsing-with-key Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
…0.32fe2e20 published by rtyley rtyley published release version 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-04T2020.32fe2e20 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-04T2020.32fe2e20 Release-Initiated-By: https://github.com/rtyley Release-Workflow-Run: https://github.com/guardian/etag-caching/actions/runs/17475700288 Release-Notes: #110
|
@rtyley has published a preview version of this PR with release workflow run #245, based on commit 32fe2e2: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-04T2020.32fe2e20 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the support-fetching-then-parsing-with-key branch, or use the GitHub CLI command: gh workflow run release.yml --ref support-fetching-then-parsing-with-key Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
7e930c6 to
99bd01e
Compare
32fe2e2 to
3b4c706
Compare
…3.3b4c7060 published by rtyley rtyley published release version 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-09T0923.3b4c7060 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-09T0923.3b4c7060 Release-Initiated-By: https://github.com/rtyley Release-Workflow-Run: https://github.com/guardian/etag-caching/actions/runs/17578030467 Release-Notes: #110
|
@rtyley has published a preview version of this PR with release workflow run #248, based on commit 3b4c706: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-09-09T0923.3b4c7060 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the support-fetching-then-parsing-with-key branch, or use the GitHub CLI command: gh workflow run release.yml --ref support-fetching-then-parsing-with-key Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
98f5f71 to
e75cbd5
Compare
70d2211 to
9a84353
Compare
9c9ee97 to
e50fc02
Compare
7469c06 to
fe41f56
Compare
0bb7706 to
c3dc18a
Compare
fe41f56 to
639c6ec
Compare
c3dc18a to
271b674
Compare
# Conflicts: # core/src/test/scala/com/gu/etagcaching/LoadingTest.scala
639c6ec to
abf81f8
Compare
…9.abf81f84 published by rtyley rtyley published release version 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-10-10T2129.abf81f84 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-10-10T2129.abf81f84 Release-Initiated-By: https://github.com/rtyley Release-Workflow-Run: https://github.com/guardian/etag-caching/actions/runs/18418888067 Release-Notes: #110
|
@rtyley has published a preview version of this PR with release workflow run #251, based on commit abf81f8: 11.0.0-PREVIEW.support-fetching-then-parsing-with-key.2025-10-10T2129.abf81f84 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the support-fetching-then-parsing-with-key branch, or use the GitHub CLI command: gh workflow run release.yml --ref support-fetching-then-parsing-with-key Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
This is motivated by fixing Prout's flakey integration tests:
com.gu.etag-caching, adopt Cats Effect (IO) rtyley/play-git-hub#18 - the failures were partly caused by bad caching behaviour in OkHttp, which occasionally was not refreshing the cached responses of conditional requests to the GitHub API. To fix this,play-git-hubhas switched to use our ownetag-cachinglibrary instead.The one blocker for
play-git-hubusing our ownetag-cachinglibrary is that the library currently only provides the response to the parser. Yet GitHub API responses do not contain a discriminator which makes it easy to work out what the correct parser is to use - is the response aRepo, aPullRequestor what!? Therefore we needetag-cachingto support parser functions that require knowledge of the key, as well as the raw response.Changes
fetching.thenParsingWithKey()syntax to complement thefetching.thenParsing()method of instantiating aLoadinginstance - which passes thekey, as well as the rawresponse, to the parser.Loading.by(fetching)(parser)syntax for instantiating aLoadinginstance, in favour of the alternativefetching.thenParsing(parser)syntax (which previously delegated toLoading.by(fetching)(parser)). We don't need two syntaxes for doing the same thing, and thefetching.thenParsing(parser)syntax seems more convenient. I definitely didn't want to have the 2x2 matrix of methods covering with/without-key * located-on-Loading/Fetching.